Review of attachment 9121986 [details] [diff] [review]: ----------------------------------------------------------------- Richard, thanks for picking this up. Can we polish this a bit more along the alert proposal of my comment 7? I understood that Alessandro is fine with that, too. ::: mail/locales/en-US/chrome/messenger/messengercompose/composeMsgs.properties @@ +484,5 @@ > identityWarning=A unique identity matching the From address was not found. The message will be sent using the current From field and settings from identity %S. > > ## Recipient pills fileds. > ## LOCALIZATION NOTE(confirmRemoveRecipientRowTitle): %S will be replaced with the field name. > confirmRemoveRecipientRowTitle=Remove %S The alert title looks incomplete to me. I think we really need to say "Remove %S recipients" @@ +490,1 @@ > confirmRemoveRecipientRowBody=All the addresses in the %S field will be removed. Do you want to proceed? As I tried to explain in my alert proposal of comment 7, I think this alert message is too verbose, and we should follow best practices for confirmation dialogs which I referenced. Just **|Remove all recipients of the type "%s"|** would suffice imo for the alert body message, and much easier to parse. "Do you want to proceed?" looks really clumsy, outdated, and suggesting a big danger which isn't the case, and it doesn't add any useful information, just clutter. I don't know how hard it is to change the alert's default button caption to become [Remove], but it must be doable and it should be done. OK buttons which don't make their action explicit are also quite outdated.
Bug 1609977 Comment 11 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
Review of attachment 9121986 [details] [diff] [review]: ----------------------------------------------------------------- Richard, thanks for picking this up. Can we polish this a bit more along the alert proposal of my comment 7? I understood that Alessandro is fine with that, too. ::: mail/locales/en-US/chrome/messenger/messengercompose/composeMsgs.properties @@ +484,5 @@ > identityWarning=A unique identity matching the From address was not found. The message will be sent using the current From field and settings from identity %S. > > ## Recipient pills fileds. > ## LOCALIZATION NOTE(confirmRemoveRecipientRowTitle): %S will be replaced with the field name. > confirmRemoveRecipientRowTitle=Remove %S The alert title looks incomplete to me. I think we really need to say "Remove %S recipients" @@ +490,1 @@ > confirmRemoveRecipientRowBody=All the addresses in the %S field will be removed. Do you want to proceed? As I tried to explain in my alert proposal of comment 7, I think this alert message is too verbose, and we should follow best practices for confirmation dialogs which I referenced. Just **|Remove all recipients of the type "%s"?|** would suffice imo for the alert body message, and much easier to parse. "Do you want to proceed?" looks really clumsy, outdated, and suggesting a big danger which isn't the case, and it doesn't add any useful information, just clutter. I don't know how hard it is to change the alert's default button caption to become [Remove], but it must be doable and it should be done. OK buttons which don't make their action explicit are also quite outdated.