Bug 1610023 Comment 8 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Review of attachment 9122291 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for the review Khushil.  I took a look, and happened to notice a couple things.

::: mail/test/browser/message-header/browser_messageHeader.js
@@ +905,5 @@
>    // get maxline pref
>    let maxLines = Services.prefs.getIntPref(
>      "mailnews.headers.show_n_lines_before_more"
>    );
> +  dump("xxxmagnus test maxLines=" + maxLines + "\n");

Looks like some dev debugging code that should be deleted?

::: mailnews/test/resources/folderEventLogHelper.js
@@ +58,5 @@
>      let args = [
>        aJunkProcessed ? "junk processed" : "did not junk process",
>        aTraitProcessed ? "trait processed" : "did not trait process",
>      ];
> +    dump("xxxmagnus aMsgs=" + aMsgs + "\n");

Here too.
Review of attachment 9122291 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for the review Khushil.  I took a quick look, and happened to notice a couple things.

::: mail/test/browser/message-header/browser_messageHeader.js
@@ +905,5 @@
>    // get maxline pref
>    let maxLines = Services.prefs.getIntPref(
>      "mailnews.headers.show_n_lines_before_more"
>    );
> +  dump("xxxmagnus test maxLines=" + maxLines + "\n");

Looks like some dev debugging code that should be deleted?

::: mailnews/test/resources/folderEventLogHelper.js
@@ +58,5 @@
>      let args = [
>        aJunkProcessed ? "junk processed" : "did not junk process",
>        aTraitProcessed ? "trait processed" : "did not trait process",
>      ];
> +    dump("xxxmagnus aMsgs=" + aMsgs + "\n");

Here too.

Back to Bug 1610023 Comment 8