Bug 1610137 Comment 1 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Original comment by

Alex Thayer [:alexical] (she/her)

on 2020-01-18 14:54:20 PST

Is the `profiler_shutdown` call in AppShutdown.cpp in this revision acceptable for this? [link](https://phabricator.services.mozilla.com/D59196#change-p5CDbBs2wi89)

I'm 95% certain I tested `MOZ_PROFILER_SHUTDOWN` when implementing it, but I don't know if there are special cases that could make it incorrect.

Revision 1 by

Alex Thayer [:alexical] (she/her)

on 2020-01-18 14:54:48 PST

Is the `profiler_shutdown` call in AppShutdown.cpp in this  [revision](https://phabricator.services.mozilla.com/D59196#change-p5CDbBs2wi89)
 acceptable for this?
I'm 95% certain I tested `MOZ_PROFILER_SHUTDOWN` when implementing it, but I don't know if there are special cases that could make it incorrect.

Revision 2 by

Alex Thayer [:alexical] (she/her)

on 2020-01-18 14:54:58 PST

Is the `profiler_shutdown` call in AppShutdown.cpp in this  [revision](https://phabricator.services.mozilla.com/D59196#change-p5CDbBs2wi89) acceptable for this?
I'm 95% certain I tested `MOZ_PROFILER_SHUTDOWN` when implementing it, but I don't know if there are special cases that could make it incorrect.

Back to Bug 1610137 Comment 1