(In reply to Alessandro Castellani [:aleca] from comment #78) > Review of attachment 9220777 [details] [diff] [review] Perfect review with a keen eye for the detail, thank you! This patch addresses all nits of comment 78. Trying to eliminate the <textbox> notion has resulted in a more aggressive rewrite of the existing functions according to our "generic event handlers" best practice. I also like shrinking and disentangling code. * Code cleanup; use generic event handler functions and eliminate duplication. * Safeguard against space-padding of the auto-Cc/Bcc address list to ensure its visibility in the input field; now that we allow empty input, someone might think of exploiting that.
Bug 1616514 Comment 79 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
(In reply to Alessandro Castellani [:aleca] from comment #78) > Review of attachment 9220777 [details] [diff] [review] Perfect review with a keen eye for the detail, thank you! This patch addresses all nits of comment 78. Trying to eliminate the <textbox> notion has resulted in a more aggressive rewrite of the existing functions according to our "generic event handlers" best practice. I also like shrinking and disentangling code. * Code cleanup; use generic event handler functions and eliminate duplication. * Safeguard against space-padding of the auto-Cc/Bcc address list to ensure its visibility in the input field; now that we allow empty input, someone might think of exploiting that.
(In reply to Alessandro Castellani [:aleca] from comment #78) > Review of attachment 9220777 [details] [diff] [review] Perfect review with a keen eye for the detail, thank you! This patch addresses all nits of comment 78. Trying to eliminate the <textbox> notion has resulted in a more aggressive rewrite of the existing functions according to our "generic event handlers" best practice. I also like shrinking and disentangling code. * Code cleanup; use generic event handler functions and eliminate duplication. * Safeguard against space-padding of the auto-Cc/Bcc address list to ensure its visibility in the input field; now that we allow empty input, someone might think of exploiting that. I'm only preventing the most basic case of unwanted whitespace-padding (using *traditional* whitespace characters), so it's probably more of a neat string thing...
(In reply to Alessandro Castellani [:aleca] from comment #78) > Review of attachment 9220777 [details] [diff] [review] Perfect review with a keen eye for the detail, thank you! This patch addresses all nits of comment 78. Trying to eliminate the <textbox> notion has resulted in a more aggressive rewrite of the existing functions according to our "generic event handlers" best practice. I also like shrinking and disentangling code. * Code cleanup; use generic event handler functions and eliminate duplication. * Safeguard against whitespace-padding of the auto-Cc/Bcc address list to ensure its visibility in the input field; now that we allow empty input, someone might think of exploiting that. I'm only preventing the most basic case of unwanted whitespace-padding (using *traditional* whitespace characters), so it's probably more of a neat string thing...
(In reply to Alessandro Castellani [:aleca] from comment #78) > Review of attachment 9220777 [details] [diff] [review] Perfect review with a keen eye for the detail, thank you! This patch addresses all nits of comment 78. Trying to eliminate the <textbox> notion has resulted in a more aggressive rewrite of the existing functions according to our "generic event handlers" best practice. I also like shrinking and disentangling code. * Code cleanup; use generic event handler functions and eliminate duplication. * Safeguard against whitespace-padding of the auto-Cc/Bcc address list to ensure its visibility in the input field; now that we allow empty input, someone might think of exploiting that. I'm only preventing the most basic cases of unwanted whitespace-padding (using *traditional* whitespace characters), so it's probably more of a neat string thing...
(In reply to Alessandro Castellani [:aleca] from comment #78) > Review of attachment 9220777 [details] [diff] [review] Perfect review with a keen eye for the detail, thank you! This patch addresses all nits of comment 78. Trying to eliminate the <textbox> notion has resulted in a more aggressive rewrite of the existing functions according to our "generic event handlers" best practice. I also like shrinking and disentangling code. * Code cleanup; use generic event handler functions and eliminate duplication. * Safeguard against whitespace-padding of the auto-Cc/Bcc address list to ensure its visibility in the input field; now that we allow empty input, you might shoot yourself in the foot with an unfortunate copy/paste, or someone might think of exploiting that. I'm only preventing the most basic cases of unwanted whitespace-padding (using *traditional* whitespace characters), so it's probably more of a neat string thing...