Bug 1619108 Comment 31 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Original comment by
on 
Cersion1 1. switches openAsExternal to using the new function too. I doubt I will find the time to do other enhancements soon so lets get this reviewed first and worry later (hopefully without new problems).

[Approval Request Comment]
Regression caused by (bug #): Bug 1378089
User impact if declined: Unable to set defaults for opening bookmarks from the library wia prefs.
Testing completed (on m-c, etc.):  2.53.17b1 pre
Risk to taking this patch (and alternatives if risky): Mostly trivial 
String changes made by this patch: none
Revision 1 by
on 
Cersion1 1. switches openAsExternal to using the new function too. I doubt I will find the time to do other enhancements soon so lets get this reviewed first and worry later (hopefully without new problems).

[Approval Request Comment]
Regression caused by (bug #): Bug 1378089
User impact if declined: Unable to set defaults for opening bookmarks from the library via prefs.
Testing completed (on m-c, etc.):  2.53.17b1 pre
Risk to taking this patch (and alternatives if risky): Mostly trivial 
String changes made by this patch: none
Revision 2 by
on 
Version 1 1. switches openAsExternal to using the new function too. I doubt I will find the time to do other enhancements soon so lets get this reviewed first and worry later (hopefully without new problems).

[Approval Request Comment]
Regression caused by (bug #): Bug 1378089
User impact if declined: Unable to set defaults for opening bookmarks from the library via prefs.
Testing completed (on m-c, etc.):  2.53.17b1 pre
Risk to taking this patch (and alternatives if risky): Mostly trivial 
String changes made by this patch: none

Back to Bug 1619108 Comment 31