Bug 1619157 Comment 0 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

### STR ###

1) composition with contacts side bar, ensure "All Address Books" is shown
2) select a contact from "All Address Books" view (contact originates from "Personal AB")
3) press DEL
4) repeat same STR for Mailing list from "All Address Books" view (mailing list originates from "Personal AB")

This works in current release version 68.5.0 (32-Bit),
but fails on Trunk 75.0a1 (2020-02-27) (64-bit), so it's a regression.

Alice, would you like to find the regression window? No obligations, just asking if.

### Actual result ###

- deleting contact from "All ABs" view does nothing, 2 errors in console:
````
TypeError: can't access property "isMailList", selectedDir is null abCommon.js:429:11
    AbDelete chrome://messenger/content/addressbook/abCommon.js:429
    doCommand chrome://messenger/content/addressbook/abResultsPane.js:519
    goDoCommand chrome://global/content/globalOverlay.js:101
    oncommand chrome://messenger/content/messengercompose/messengercompose.xhtml:1

An error occurred executing the cmd_delete command: [Exception... "[JavaScript Error: "can't access property "isMailList", selectedDir is null" {file: "chrome://messenger/content/addressbook/abCommon.js" line: 429}]'[JavaScript Error: "can't access property "isMailList", selectedDir is null" {file: "chrome://messenger/content/addressbook/abCommon.js" line: 429}]' when calling method: [nsIController::doCommand]"  nsresult: "0x80570021 (NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS)"  location: "JS frame :: chrome://global/content/globalOverlay.js :: goDoCommand :: line 101"  data: yes] globalOverlay.js:104
    goDoCommand chrome://global/content/globalOverlay.js:104
    oncommand chrome://messenger/content/messengercompose/messengercompose.xhtml:1
````
- deleting a *mailing list* from "All Abs" view shows confirmation, but confirming does nothing, 2 Errors in console:
````
TypeError: can't access property "URI", selectedDir is null abCommon.js:495:7

An error occurred executing the cmd_delete command: [Exception... "[JavaScript Error: "can't access property "URI", selectedDir is null" {file: "chrome://messenger/content/addressbook/abCommon.js" line: 495}]'[JavaScript Error: "can't access property "URI", selectedDir is null" {file: "chrome://messenger/content/addressbook/abCommon.js" line: 495}]' when calling method: [nsIController::doCommand]"  nsresult: "0x80570021 (NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS)"  location: "JS frame :: chrome://global/content/globalOverlay.js :: goDoCommand :: line 101"  data: yes] globalOverlay.js:104
````

### Expected: ###
- delete selected entries (this bug)
- select and scroll into view next entry if existing, otherwise last entry (and focus something useful when there's no entry left)
### STR ###

1) composition with contacts side bar, ensure "All Address Books" is shown
2) select a contact from "All Address Books" view (contact originates from "Personal AB")
3) press DEL
4) repeat same STR for Mailing list from "All Address Books" view (mailing list originates from "Personal AB")

This works in current release version 68.5.0 (32-Bit),
but fails on Trunk 75.0a1 (2020-02-27) (64-bit), so it's a regression.

Alice, would you like to find the regression window? No obligations, just asking if.

### Actual result ###

- deleting contact from "All ABs" view does nothing, 2 errors in console:
````
TypeError: can't access property "isMailList", selectedDir is null abCommon.js:429:11
    AbDelete chrome://messenger/content/addressbook/abCommon.js:429
    doCommand chrome://messenger/content/addressbook/abResultsPane.js:519
    goDoCommand chrome://global/content/globalOverlay.js:101
    oncommand chrome://messenger/content/messengercompose/messengercompose.xhtml:1

An error occurred executing the cmd_delete command: [Exception... "[JavaScript Error: "can't access property "isMailList", selectedDir is null" {file: "chrome://messenger/content/addressbook/abCommon.js" line: 429}]'[JavaScript Error: "can't access property "isMailList", selectedDir is null" {file: "chrome://messenger/content/addressbook/abCommon.js" line: 429}]' when calling method: [nsIController::doCommand]"  nsresult: "0x80570021 (NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS)"  location: "JS frame :: chrome://global/content/globalOverlay.js :: goDoCommand :: line 101"  data: yes] globalOverlay.js:104
    goDoCommand chrome://global/content/globalOverlay.js:104
    oncommand chrome://messenger/content/messengercompose/messengercompose.xhtml:1
````
- deleting a *mailing list* from "All Abs" view shows confirmation, but confirming does nothing, 2 Errors in console:
````
TypeError: can't access property "URI", selectedDir is null abCommon.js:495:7

An error occurred executing the cmd_delete command: [Exception... "[JavaScript Error: "can't access property "URI", selectedDir is null" {file: "chrome://messenger/content/addressbook/abCommon.js" line: 495}]'[JavaScript Error: "can't access property "URI", selectedDir is null" {file: "chrome://messenger/content/addressbook/abCommon.js" line: 495}]' when calling method: [nsIController::doCommand]"  nsresult: "0x80570021 (NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS)"  location: "JS frame :: chrome://global/content/globalOverlay.js :: goDoCommand :: line 101"  data: yes] globalOverlay.js:104
    goDoCommand chrome://global/content/globalOverlay.js:104
    oncommand chrome://messenger/content/addressbook/abContactsPanel.xhtml:1
````

### Expected: ###
- delete selected entries (this bug)
- select and scroll into view next entry if existing, otherwise last entry (and focus something useful when there's no entry left)

Back to Bug 1619157 Comment 0