Bug 1621445 Comment 34 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Landed this for the next 2.53.9b1 pre 
The patch is basically a mixup of Fx 56 and 60. sanitizer.jsm is a copy of the 60 version plus our addtions and minus telemetry.

The dialog now contains the time range but I removed the silly drop down in Fx.
The time range is not honored by all sanitizers and all data will be deleted. This is now how it is in Fx too. 
The height will jump if you switch the range back and for to verything. Same as in Fx. Hint to do it better appreciated.

One additional item site settings has been added. Trying to keep the access keys distinct is a loosing game so I gave up. They will cycle if you use them and that is ok for me.

suite/modules/OfflineAppCacheHelper.jsm has been added. I thought first to split this but it is a 1K file and trivial. Was moved to toolkit in Fx later and deleted in 90 so you will no longer find it there. It was also named offlineAppCache.jsm which I found confusing given the function it exposes and the lower case.

2.57 might need an addtional patch on top. I think the prefpane stuff gone from it. Will test and fix later.

Tested the dialog and the shutdown function and unlike the current code seems to do the job.
Landed this for the next 2.53.9b1 pre 
The patch is basically a mixup of Fx 56 and 60. sanitizer.jsm is a copy of the 60 version plus our addtions and minus telemetry.

The dialog now contains the time range but I removed the silly drop down in Fx.
The time range is not honored by all sanitizers and all data will be deleted. This is now how it is in Fx too. 
The height will jump if you switch the range back and for to evrything. Same as in Fx. Hint to do it better appreciated.

One additional item site settings has been added. Trying to keep the access keys distinct is a loosing game so I gave up. They will cycle if you use them and that is ok for me.

suite/modules/OfflineAppCacheHelper.jsm has been added. I thought first to split this but it is a 1K file and trivial. Was moved to toolkit in Fx later and deleted in 90 so you will no longer find it there. It was also named offlineAppCache.jsm which I found confusing given the function it exposes and the lower case.

2.57 might need an addtional patch on top. I think the prefpane stuff gone from it. Will test and fix later.

Tested the dialog and the shutdown function and unlike the current code seems to do the job.
Landed this for the next 2.53.9b1 pre 
The patch is basically a mixup of Fx 56 and 60. sanitizer.jsm is a copy of the 60 version plus our additions for passwords and location bar and minus telemetry.

The dialog now contains the time range but I removed the silly drop down in Fx.
The time range is not honored by all sanitizers and all data will be deleted. This is now how it is in Fx too. 
The height will jump if you switch the range back and for to evrything. Same as in Fx. Hint to do it better appreciated.

One additional item site settings has been added. Trying to keep the access keys distinct is a loosing game so I gave up. They will cycle if you use them and that is ok for me.

suite/modules/OfflineAppCacheHelper.jsm has been added. I thought first to split this but it is a 1K file and trivial. Was moved to toolkit in Fx later and deleted in 90 so you will no longer find it there. It was also named offlineAppCache.jsm which I found confusing given the function it exposes and the lower case.

2.57 might need an addtional patch on top. I think the prefpane stuff gone from it. Will test and fix later.

Tested the dialog and the shutdown function and unlike the current code seems to do the job.

Back to Bug 1621445 Comment 34