Bug 1621762 Comment 12 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Original comment by

Daniel Varga [:dvarga]

on 2020-04-29 20:09:49 PDT

Backed out 7 changesets (Bug 1621762) for causing build bustages at builds/worker/workspace/obj-build/dist/include/mozilla/dom/ProducerConsumerQueue.h

Push with failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedTaskRun=AS60ai1rQ8mRy_cBIg3xhA-0&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&revision=03903e8f368ef71e0624daa0a960b3b35d5518f2

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=300134986&repo=autoland&lineNumber=21844

Backout link: 

```
[task 2020-04-30T02:57:22.199Z] 02:57:22     INFO -  In file included from /builds/worker/workspace/obj-build/dist/include/mozilla/dom/WebGLCommandQueue.h:10:0,
[task 2020-04-30T02:57:22.199Z] 02:57:22     INFO -                   from /builds/worker/workspace/obj-build/dist/include/mozilla/dom/WebGLCrossProcessCommandQueue.h:9,
[task 2020-04-30T02:57:22.199Z] 02:57:22     INFO -                   from /builds/worker/workspace/obj-build/ipc/ipdl/_ipdlheaders/mozilla/dom/PWebGLParent.h:21,
[task 2020-04-30T02:57:22.200Z] 02:57:22     INFO -                   from PCompositorBridge.cpp:26,
[task 2020-04-30T02:57:22.200Z] 02:57:22     INFO -                   from UnifiedProtocols11.cpp:83:
[task 2020-04-30T02:57:22.200Z] 02:57:22    ERROR -  /builds/worker/workspace/obj-build/dist/include/mozilla/dom/ProducerConsumerQueue.h:815:13: error: explicit specialization in non-namespace scope 'class mozilla::webgl::PcqConsumer'
[task 2020-04-30T02:57:22.201Z] 02:57:22     INFO -     template <>
[task 2020-04-30T02:57:22.201Z] 02:57:22     INFO -               ^
[task 2020-04-30T02:57:22.201Z] 02:57:22    ERROR -  /builds/worker/workspace/obj-build/dist/include/mozilla/dom/ProducerConsumerQueue.h:823:15: error: too many template-parameter-lists
[task 2020-04-30T02:57:22.201Z] 02:57:22     INFO -     QueueStatus TryCopyOrSkipItem(ConsumerView<PcqConsumer>& aView, Arg* aArg) {
[task 2020-04-30T02:57:22.201Z] 02:57:22     INFO -                 ^~~~~~~~~~~~~~~~~
[task 2020-04-30T02:57:22.201Z] 02:57:22    ERROR -  /builds/worker/workspace/obj-build/dist/include/mozilla/dom/ProducerConsumerQueue.h:829:15: error: too many template-parameter-lists
[task 2020-04-30T02:57:22.201Z] 02:57:22     INFO -     QueueStatus ReadObject(size_t* aRead, size_t aWrite, Arg* arg,
[task 2020-04-30T02:57:22.201Z] 02:57:22     INFO -                 ^~~~~~~~~~
[task 2020-04-30T02:57:22.201Z] 02:57:22     INFO -  /builds/worker/workspace/obj-build/dist/include/mozilla/dom/ProducerConsumerQueue.h: In member function 'mozilla::webgl::QueueStatus mozilla::webgl::PcqConsumer::TryPeekRemoveHelper(mozilla::webgl::ConsumerView<mozilla::webgl::PcqConsumer>&, Arg*, Args* ...)':
[task 2020-04-30T02:57:22.201Z] 02:57:22    ERROR -  /builds/worker/workspace/obj-build/dist/include/mozilla/dom/ProducerConsumerQueue.h:810:26: error: 'TryCopyOrSkipItem' was not declared in this scope
[task 2020-04-30T02:57:22.201Z] 02:57:22     INFO -       QueueStatus status = TryCopyOrSkipItem<Arg>(aView, aArg);
[task 2020-04-30T02:57:22.201Z] 02:57:22     INFO -                            ^~~~~~~~~~~~~~~~~
[task 2020-04-30T02:57:22.201Z] 02:57:22    ERROR -  /builds/worker/workspace/obj-build/dist/include/mozilla/dom/ProducerConsumerQueue.h:810:47: error: expected primary-expression before '>' token
[task 2020-04-30T02:57:22.201Z] 02:57:22     INFO -       QueueStatus status = TryCopyOrSkipItem<Arg>(aView, aArg);
[task 2020-04-30T02:57:22.201Z] 02:57:22     INFO -                                                 ^
[task 2020-04-30T02:57:22.202Z] 02:57:22     INFO -  In file included from /builds/worker/workspace/obj-build/dist/include/mozilla/dom/WebGLCrossProcessCommandQueue.h:9:0,
[task 2020-04-30T02:57:22.202Z] 02:57:22     INFO -                   from /builds/worker/workspace/obj-build/ipc/ipdl/_ipdlheaders/mozilla/dom/PWebGLParent.h:21,
[task 2020-04-30T02:57:22.202Z] 02:57:22     INFO -                   from PCompositorBridge.cpp:26,
[task 2020-04-30T02:57:22.202Z] 02:57:22     INFO -                   from UnifiedProtocols11.cpp:83:
[task 2020-04-30T02:57:22.202Z] 02:57:22     INFO -  /builds/worker/workspace/obj-build/dist/include/mozilla/dom/WebGLCommandQueue.h: At global scope:
[task 2020-04-30T02:57:22.202Z] 02:57:22    ERROR -  /builds/worker/workspace/obj-build/dist/include/mozilla/dom/WebGLCommandQueue.h:513:13: error: explicit specialization in non-namespace scope 'struct mozilla::MethodDispatcher<Derived>'
[task 2020-04-30T02:57:22.202Z] 02:57:22     INFO -     template <>
[task 2020-04-30T02:57:22.202Z] 02:57:22     INFO -               ^
[task 2020-04-30T02:57:22.202Z] 02:57:22    ERROR -  /builds/worker/workspace/obj-build/dist/include/mozilla/dom/WebGLCommandQueue.h:514:10: error: template parameters not deducible in partial specialization:
[task 2020-04-30T02:57:22.203Z] 02:57:22     INFO -     struct DispatchMethod<CommandSyncType::ASYNC> {
[task 2020-04-30T02:57:22.203Z] 02:57:22     INFO -            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
[task 2020-04-30T02:57:22.203Z] 02:57:22     INFO -  /builds/worker/workspace/obj-build/dist/include/mozilla/dom/WebGLCommandQueue.h:514:10: note:         'Derived'
[task 2020-04-30T02:57:22.203Z] 02:57:22    ERROR -  /builds/worker/workspace/obj-build/dist/include/mozilla/dom/WebGLCommandQueue.h:523:13: error: explicit specialization in non-namespace scope 'struct mozilla::MethodDispatcher<Derived>'
[task 2020-04-30T02:57:22.203Z] 02:57:22     INFO -     template <>
[task 2020-04-30T02:57:22.203Z] 02:57:22     INFO -               ^
[task 2020-04-30T02:57:22.203Z] 02:57:22    ERROR -  /builds/worker/workspace/obj-build/dist/include/mozilla/dom/WebGLCommandQueue.h:524:10: error: template parameters not deducible in partial specialization:
[task 2020-04-30T02:57:22.203Z] 02:57:22     INFO -     struct DispatchMethod<CommandSyncType::SYNC> {
[task 2020-04-30T02:57:22.203Z] 02:57:22     INFO -            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```

Revision 1 by

Daniel Varga [:dvarga]

on 2020-04-29 20:10:08 PDT

(Hidden by Administrator)

Revision 2 by

Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)

on 2020-04-30 02:58:31 PDT

Backed out 7 changesets (Bug 1621762) for causing build bustages at builds/worker/workspace/obj-build/dist/include/mozilla/dom/ProducerConsumerQueue.h

Push with failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedTaskRun=AS60ai1rQ8mRy_cBIg3xhA-0&resultStatus=testfailed%2Cbusted%2Cexception&revision=03903e8f368ef71e0624daa0a960b3b35d5518f2

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=300134986&repo=autoland&lineNumber=21844

Backout link: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&revision=f5b6bbac55bc2d9e8f49e7fdc21dcfccd03e3952

```
[task 2020-04-30T02:57:22.199Z] 02:57:22     INFO -  In file included from /builds/worker/workspace/obj-build/dist/include/mozilla/dom/WebGLCommandQueue.h:10:0,
[task 2020-04-30T02:57:22.199Z] 02:57:22     INFO -                   from /builds/worker/workspace/obj-build/dist/include/mozilla/dom/WebGLCrossProcessCommandQueue.h:9,
[task 2020-04-30T02:57:22.199Z] 02:57:22     INFO -                   from /builds/worker/workspace/obj-build/ipc/ipdl/_ipdlheaders/mozilla/dom/PWebGLParent.h:21,
[task 2020-04-30T02:57:22.200Z] 02:57:22     INFO -                   from PCompositorBridge.cpp:26,
[task 2020-04-30T02:57:22.200Z] 02:57:22     INFO -                   from UnifiedProtocols11.cpp:83:
[task 2020-04-30T02:57:22.200Z] 02:57:22    ERROR -  /builds/worker/workspace/obj-build/dist/include/mozilla/dom/ProducerConsumerQueue.h:815:13: error: explicit specialization in non-namespace scope 'class mozilla::webgl::PcqConsumer'
[task 2020-04-30T02:57:22.201Z] 02:57:22     INFO -     template <>
[task 2020-04-30T02:57:22.201Z] 02:57:22     INFO -               ^
[task 2020-04-30T02:57:22.201Z] 02:57:22    ERROR -  /builds/worker/workspace/obj-build/dist/include/mozilla/dom/ProducerConsumerQueue.h:823:15: error: too many template-parameter-lists
[task 2020-04-30T02:57:22.201Z] 02:57:22     INFO -     QueueStatus TryCopyOrSkipItem(ConsumerView<PcqConsumer>& aView, Arg* aArg) {
[task 2020-04-30T02:57:22.201Z] 02:57:22     INFO -                 ^~~~~~~~~~~~~~~~~
[task 2020-04-30T02:57:22.201Z] 02:57:22    ERROR -  /builds/worker/workspace/obj-build/dist/include/mozilla/dom/ProducerConsumerQueue.h:829:15: error: too many template-parameter-lists
[task 2020-04-30T02:57:22.201Z] 02:57:22     INFO -     QueueStatus ReadObject(size_t* aRead, size_t aWrite, Arg* arg,
[task 2020-04-30T02:57:22.201Z] 02:57:22     INFO -                 ^~~~~~~~~~
[task 2020-04-30T02:57:22.201Z] 02:57:22     INFO -  /builds/worker/workspace/obj-build/dist/include/mozilla/dom/ProducerConsumerQueue.h: In member function 'mozilla::webgl::QueueStatus mozilla::webgl::PcqConsumer::TryPeekRemoveHelper(mozilla::webgl::ConsumerView<mozilla::webgl::PcqConsumer>&, Arg*, Args* ...)':
[task 2020-04-30T02:57:22.201Z] 02:57:22    ERROR -  /builds/worker/workspace/obj-build/dist/include/mozilla/dom/ProducerConsumerQueue.h:810:26: error: 'TryCopyOrSkipItem' was not declared in this scope
[task 2020-04-30T02:57:22.201Z] 02:57:22     INFO -       QueueStatus status = TryCopyOrSkipItem<Arg>(aView, aArg);
[task 2020-04-30T02:57:22.201Z] 02:57:22     INFO -                            ^~~~~~~~~~~~~~~~~
[task 2020-04-30T02:57:22.201Z] 02:57:22    ERROR -  /builds/worker/workspace/obj-build/dist/include/mozilla/dom/ProducerConsumerQueue.h:810:47: error: expected primary-expression before '>' token
[task 2020-04-30T02:57:22.201Z] 02:57:22     INFO -       QueueStatus status = TryCopyOrSkipItem<Arg>(aView, aArg);
[task 2020-04-30T02:57:22.201Z] 02:57:22     INFO -                                                 ^
[task 2020-04-30T02:57:22.202Z] 02:57:22     INFO -  In file included from /builds/worker/workspace/obj-build/dist/include/mozilla/dom/WebGLCrossProcessCommandQueue.h:9:0,
[task 2020-04-30T02:57:22.202Z] 02:57:22     INFO -                   from /builds/worker/workspace/obj-build/ipc/ipdl/_ipdlheaders/mozilla/dom/PWebGLParent.h:21,
[task 2020-04-30T02:57:22.202Z] 02:57:22     INFO -                   from PCompositorBridge.cpp:26,
[task 2020-04-30T02:57:22.202Z] 02:57:22     INFO -                   from UnifiedProtocols11.cpp:83:
[task 2020-04-30T02:57:22.202Z] 02:57:22     INFO -  /builds/worker/workspace/obj-build/dist/include/mozilla/dom/WebGLCommandQueue.h: At global scope:
[task 2020-04-30T02:57:22.202Z] 02:57:22    ERROR -  /builds/worker/workspace/obj-build/dist/include/mozilla/dom/WebGLCommandQueue.h:513:13: error: explicit specialization in non-namespace scope 'struct mozilla::MethodDispatcher<Derived>'
[task 2020-04-30T02:57:22.202Z] 02:57:22     INFO -     template <>
[task 2020-04-30T02:57:22.202Z] 02:57:22     INFO -               ^
[task 2020-04-30T02:57:22.202Z] 02:57:22    ERROR -  /builds/worker/workspace/obj-build/dist/include/mozilla/dom/WebGLCommandQueue.h:514:10: error: template parameters not deducible in partial specialization:
[task 2020-04-30T02:57:22.203Z] 02:57:22     INFO -     struct DispatchMethod<CommandSyncType::ASYNC> {
[task 2020-04-30T02:57:22.203Z] 02:57:22     INFO -            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
[task 2020-04-30T02:57:22.203Z] 02:57:22     INFO -  /builds/worker/workspace/obj-build/dist/include/mozilla/dom/WebGLCommandQueue.h:514:10: note:         'Derived'
[task 2020-04-30T02:57:22.203Z] 02:57:22    ERROR -  /builds/worker/workspace/obj-build/dist/include/mozilla/dom/WebGLCommandQueue.h:523:13: error: explicit specialization in non-namespace scope 'struct mozilla::MethodDispatcher<Derived>'
[task 2020-04-30T02:57:22.203Z] 02:57:22     INFO -     template <>
[task 2020-04-30T02:57:22.203Z] 02:57:22     INFO -               ^
[task 2020-04-30T02:57:22.203Z] 02:57:22    ERROR -  /builds/worker/workspace/obj-build/dist/include/mozilla/dom/WebGLCommandQueue.h:524:10: error: template parameters not deducible in partial specialization:
[task 2020-04-30T02:57:22.203Z] 02:57:22     INFO -     struct DispatchMethod<CommandSyncType::SYNC> {
[task 2020-04-30T02:57:22.203Z] 02:57:22     INFO -            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```

Back to Bug 1621762 Comment 12