Bug 1623134 Comment 27 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Original comment by
on 
Hmm, I see a path forward. The fix for bug 1626272 can land, because it only only affects opt builds, while the change in bug 1622701 only affects debug builds. And Android testing only runs on debug builds on CI. So the path forward is this:

- Land bug 1626272, which changes `fix_stacks.py` and `utils.py`, but only for opt builds, and so doesn't affect Android tests on CI.
- Update host-utils *again*, to incorporate the changes to `fix_stacks.py` in bug 1626272.
- Land bug 1622701, which affects debug builds, and thus Android tests on try.

Goodness. If Android tests ran on opt builds as well as debug builds on CI, bug 1626272 would be impossible to fix without temporarily having some kind of fallback code to handle things if an old `fix_stack.py` is present.

This whole "Android tests use old versions of stuff" is a real time waster :(
Revision 1 by
on 
Hmm, I see a path forward. The fix for bug 1626272 can land, because it only only affects opt builds, while the change in bug 1622701 only affects debug builds. And Android testing only runs on debug builds on CI. So, we can:

- Land bug 1626272, which changes `fix_stacks.py` and `utils.py`, but only for opt builds, and so doesn't affect Android tests on CI.
- Update host-utils *again*, to incorporate the changes to `fix_stacks.py` in bug 1626272.
- Land bug 1622701, which affects debug builds, and thus Android tests on try.

Goodness. If Android tests ran on opt builds as well as debug builds on CI, bug 1626272 would be impossible to fix without temporarily having some kind of fallback code to handle things if an old `fix_stack.py` is present.

This whole "Android tests use old versions of stuff" is a real time waster :(
Revision 2 by
on 
Hmm, I see a path forward. The fix for bug 1626272 can land, because it only only affects opt builds, while the change in bug 1622701 only affects debug builds. And Android testing only runs on debug builds on CI. So, we can:

- Land bug 1626272, which changes `fix_stacks.py` and `utils.py`, but only for opt builds, which means it doesn't affect Android tests on CI.
- Update host-utils *again*, to incorporate the changes to `fix_stacks.py` in bug 1626272.
- Land bug 1622701, which affects debug builds, and thus Android tests on try.

Goodness. If Android tests ran on opt builds as well as debug builds on CI, bug 1626272 would be impossible to fix without temporarily having some kind of fallback code to handle things if an old `fix_stack.py` is present.

This whole "Android tests use old versions of stuff" is a real time waster :(
Revision 3 by
on 
Hmm, I see a path forward. The fix for bug 1626272 can land, because it only affects opt builds, while the change in bug 1622701 only affects debug builds. And Android testing only runs on debug builds on CI. So, we can:

- Land bug 1626272, which changes `fix_stacks.py` and `utils.py`, but only for opt builds, which means it doesn't affect Android tests on CI.
- Update host-utils *again*, to incorporate the changes to `fix_stacks.py` in bug 1626272.
- Land bug 1622701, which affects debug builds, and thus Android tests on try.

Goodness. If Android tests ran on opt builds as well as debug builds on CI, bug 1626272 would be impossible to fix without temporarily having some kind of fallback code to handle things if an old `fix_stack.py` is present.

This whole "Android tests use old versions of stuff" is a real time waster :(

Back to Bug 1623134 Comment 27