Bugzilla

(In reply to Mike Hommey [:glandium] from comment #15)
> (In reply to Kevin Jacobs [:kjacobs] from comment #10)
> > Please see the note added in https://developer.mozilla.org/en-US/docs/Mozilla/Projects/NSS/NSS_3.52_release_notes (in Notable Changes). If you still think there's an issue, a new bug would be appropriate.
> > 
> > This is more likely a build/configuration issue causing Firefox to pull in a pre-3.52 version of NSS.
> 
> There is nothing in Firefox that prevents building against a newer version of NSS. I suppose this means building any version of Firefox, including ESR, against NSS 3.52 breaks Firefox? What about non-Firefox? I suppose anything that builds against NSS 3.52 might be broken depending on their use of PKCS? It seems to me what needs adaptation here is NSS, not everything that uses it.

Old binaries will continue to work with 3.52 (loaded dynamically) since 3.52 uses the size of the struct to tell which definition was used. The change impacts *recompiling* with newer versions of NSS.  

Regardless, this bug is for the associated updates to Firefox. The NSS change happened in bug 1603628, and there is further discussion of this issue in D63241.  Please file a new bug in NSS if you feel this needs to be revisited.

(In reply to Mike Hommey [:glandium] from comment #15)
> (In reply to Kevin Jacobs [:kjacobs] from comment #10)
> > Please see the note added in https://developer.mozilla.org/en-US/docs/Mozilla/Projects/NSS/NSS_3.52_release_notes (in Notable Changes). If you still think there's an issue, a new bug would be appropriate.
> > 
> > This is more likely a build/configuration issue causing Firefox to pull in a pre-3.52 version of NSS.
> 
> There is nothing in Firefox that prevents building against a newer version of NSS. I suppose this means building any version of Firefox, including ESR, against NSS 3.52 breaks Firefox? What about non-Firefox? I suppose anything that builds against NSS 3.52 might be broken depending on their use of PKCS? It seems to me what needs adaptation here is NSS, not everything that uses it.

Old binaries will continue to work with 3.52 (loaded dynamically) since 3.52 uses the size of the struct to tell which definition was used. The change impacts *recompiling* with newer versions of NSS, where `NSS_PKCS11_2_0_COMPAT` to avoid any code changes.

Regardless, this bug is for the associated updates to Firefox. The NSS change happened in bug 1603628, and there is further discussion of this issue in D63241.  Please file a new bug in NSS if you feel this needs to be revisited.

(In reply to Mike Hommey [:glandium] from comment #15)
> (In reply to Kevin Jacobs [:kjacobs] from comment #10)
> > Please see the note added in https://developer.mozilla.org/en-US/docs/Mozilla/Projects/NSS/NSS_3.52_release_notes (in Notable Changes). If you still think there's an issue, a new bug would be appropriate.
> > 
> > This is more likely a build/configuration issue causing Firefox to pull in a pre-3.52 version of NSS.
> 
> There is nothing in Firefox that prevents building against a newer version of NSS. I suppose this means building any version of Firefox, including ESR, against NSS 3.52 breaks Firefox? What about non-Firefox? I suppose anything that builds against NSS 3.52 might be broken depending on their use of PKCS? It seems to me what needs adaptation here is NSS, not everything that uses it.

Old binaries will continue to work with 3.52 (loaded dynamically) since 3.52 uses the size of the struct to tell which definition was used. The change impacts *recompiling* with newer versions of NSS, where `NSS_PKCS11_2_0_COMPAT` can be used to avoid any code changes.

Regardless, this bug is for the associated updates to Firefox. The NSS change happened in bug 1603628, and there is further discussion of this issue in D63241.  Please file a new bug in NSS if you feel this needs to be revisited.