Bug 1624405 Comment 2 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

nr_ice_component_check_if_failed is called from two places, but one of those is called from a timer, which does not match this stack. The other is here:

https://searchfox.org/mozilla-central/rev/202a285024f174c2d2bf2152d9cba90a03723eab/media/mtransport/third_party/nICEr/src/ice/ice_component.c#1597

This is called from one place:

https://searchfox.org/mozilla-central/rev/202a285024f174c2d2bf2152d9cba90a03723eab/media/mtransport/third_party/nICEr/src/ice/ice_candidate_pair.c#585

This, in turn, is called from several places in nr_ice_candidate_pair_stun_cb with parameters that are consistent with the stack. So, the stack should basically look like this:

0 xul.dll nr_ice_component_check_if_failed media/mtransport/third_party/nICEr/src/ice/ice_component.c:1602
0.1 xul.dll nr_ice_component_failed_pair media/mtransport/third_party/nICEr/src/ice/ice_component.c:1597
0.2 xul.dll nr_ice_candidate_pair_set_state media/mtransport/third_party/nICEr/src/ice/ice_candidate_pair.c:552
1 xul.dll nr_ice_candidate_pair_stun_cb media/mtransport/third_party/nICEr/src/ice/ice_candidate_pair.c (possible line numbers: 221, 229, 236, 249, 304)
1.1 xul.dll nr_stun_client_fire_finished_cb media/mtransport/third_party/nICEr/src/stun/stun_client_ctx.c:123
2 xul.dll nr_stun_client_process_response media/mtransport/third_party/nICEr/src/stun/stun_client_ctx.c:822
3 xul.dll nr_ice_socket_readable_cb media/mtransport/third_party/nICEr/src/ice/ice_socket.c:114
4 xul.dll mozilla::NrUdpSocketIpc::recv_callback_s media/mtransport/nr_socket_prsock.cpp:1593
5 xul.dll mozilla::runnable_args_memfn<RefPtr<mozilla::NrUdpSocketIpc>, void  media/mtransport/runnable_utils.h:122
6 xul.dll mozilla::detail::runnable_args_base<mozilla::detail::NoResult>::Run media/mtransport/runnable_utils.h:40
7 xul.dll nsThread::ProcessNextEvent xpcom/threads/nsThread.cpp:1220
8 xul.dll NS_ProcessNextEvent xpcom/threads/nsThreadUtils.cpp:481
9 xul.dll mozilla::net::nsSocketTransportService::Run netwerk/base/nsSocketTransportService2.cpp:1135
nr_ice_component_check_if_failed is called from two places, but one of those is called from a timer, which does not match this stack. The other is here:

https://searchfox.org/mozilla-central/rev/202a285024f174c2d2bf2152d9cba90a03723eab/media/mtransport/third_party/nICEr/src/ice/ice_component.c#1597

This is called from one place:

https://searchfox.org/mozilla-central/rev/202a285024f174c2d2bf2152d9cba90a03723eab/media/mtransport/third_party/nICEr/src/ice/ice_candidate_pair.c#585

This, in turn, is called from several places in nr_ice_candidate_pair_stun_cb with parameters that are consistent with the stack. So, the stack should basically look like this:

0 xul.dll nr_ice_component_check_if_failed media/mtransport/third_party/nICEr/src/ice/ice_component.c:1602
0.1 xul.dll nr_ice_component_failed_pair media/mtransport/third_party/nICEr/src/ice/ice_component.c:1597
0.2 xul.dll nr_ice_candidate_pair_set_state media/mtransport/third_party/nICEr/src/ice/ice_candidate_pair.c:585
1 xul.dll nr_ice_candidate_pair_stun_cb media/mtransport/third_party/nICEr/src/ice/ice_candidate_pair.c (possible line numbers: 221, 229, 236, 249, 304)
1.1 xul.dll nr_stun_client_fire_finished_cb media/mtransport/third_party/nICEr/src/stun/stun_client_ctx.c:123
2 xul.dll nr_stun_client_process_response media/mtransport/third_party/nICEr/src/stun/stun_client_ctx.c:822
3 xul.dll nr_ice_socket_readable_cb media/mtransport/third_party/nICEr/src/ice/ice_socket.c:114
4 xul.dll mozilla::NrUdpSocketIpc::recv_callback_s media/mtransport/nr_socket_prsock.cpp:1593
5 xul.dll mozilla::runnable_args_memfn<RefPtr<mozilla::NrUdpSocketIpc>, void  media/mtransport/runnable_utils.h:122
6 xul.dll mozilla::detail::runnable_args_base<mozilla::detail::NoResult>::Run media/mtransport/runnable_utils.h:40
7 xul.dll nsThread::ProcessNextEvent xpcom/threads/nsThread.cpp:1220
8 xul.dll NS_ProcessNextEvent xpcom/threads/nsThreadUtils.cpp:481
9 xul.dll mozilla::net::nsSocketTransportService::Run netwerk/base/nsSocketTransportService2.cpp:1135

Back to Bug 1624405 Comment 2