Looks like the regression started with 16.9.0 react-dom on mac about_newtab_with_snippets opt e10s stylo with 3 runs: ``` 16. 8.6: 69.75 70.50 71.48 16. 9.0: 84.75 90.96 91.23 16.10.2: 83.95 85.72 90.71 16.11.0: 88.17 88.71 90.48 16.12.0: 87.24 90.30 93.13 16.13.1: 70.50 70.75 74.50 ``` And perhaps the regression was fixed in a newer version 16.13.1. I guess we can switch to the newer version or revert to 16.8.6? https://treeherder.mozilla.org/#/jobs?repo=try&group_state=expanded&searchStr=talos&fromchange=6d77b61b88260ce248005175586a4638cbbb87f1&tochange=8e6b35f6cd3ecdd44f73a19ee213d5af00b06c2e&author=edilee%40gmail.com andreio, any idea what's actually regressing "with_snippets" (but potentially not regressing other newtab talos tests)? I also ran some regression range talos runs of https://github.com/facebook/react/compare/v16.8.6...v16.9.0 with 500+ commits, and seems to be between: ``` git lg 353e0ee47..fd601fb21 packages/react-dom/ * fce15f14d - don't fire missing act() warnings for react-art (#15975) (10 months ago) <Sunil Pai> * e1c5e8720 - warn if passive effects get queued outside of an act() call. (#15763) (10 months ago) <Sunil Pai> * 6568a7993 - [Scheduler] requestPaint (#15960) (10 months ago) <Andrew Clark> * dc298fdf9 - [Flare] Refinements to useEvent hook (#15955) (10 months ago) <Dominic Gannaway> * a5ed2f98f - [Flare] Guard against stateNode being null (#15952) (10 months ago) <Dominic Gannaway> * 34ce57ae7 - [Flare] Refine flow type annotations (#15950) (10 months ago) <Dominic Gannaway> * 4f92fbce5 - [Flare] Move createEvent back to React object (#15943) (10 months ago) <Dominic Gannaway> * 175111de7 - Lazily initialize dependencies object (#15944) (10 months ago) <Andrew Clark> * 720db4cbe - [Flare] Add useEvent hook implementation (#15927) (10 months ago) <Dominic Gannaway> * ff91bfa58 - [act] reset scope depth on synchronous errors (#15937) (10 months ago) <Sunil Pai> * 76864f7ff - Add SuspenseList Component (#15902) (10 months ago) <Sebastian Markbåge> * b62ae1642 - [Flare] Rename createEventComponent -> createEvent (#15929) (10 months ago) <Dominic Gannaway> * f4e1ac8ca - [Flare] Press events include defaultPrevented (#15916) (10 months ago) <Nicolas Gallagher> * 689beef6f - [Flare] Move unstable_createEventComponent to ReactDOM (#15890) (10 months ago) <Dominic Gannaway> ``` I'm also trying to see what was changed in 16.13 that might have fixed the regression…
Bug 1627569 Comment 1 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
Looks like the regression started with 16.9.0 react-dom on mac about_newtab_with_snippets opt e10s stylo with 3 runs: ``` 16. 8.6: 69.75 70.50 71.48 16. 9.0: 84.75 90.96 91.23 16.10.2: 83.95 85.72 90.71 16.11.0: 88.17 88.71 90.48 16.12.0: 87.24 90.30 93.13 16.13.1: 70.50 70.75 74.50 ``` And perhaps the regression was fixed in a newer version 16.13.1. I guess we can switch to the newer version or revert to 16.8.6? https://github.com/facebook/react/blob/master/CHANGELOG.md#16131-march-19-2020 https://treeherder.mozilla.org/#/jobs?repo=try&group_state=expanded&searchStr=talos&fromchange=6d77b61b88260ce248005175586a4638cbbb87f1&tochange=8e6b35f6cd3ecdd44f73a19ee213d5af00b06c2e&author=edilee%40gmail.com andreio, any idea what's actually regressing "with_snippets" (but potentially not regressing other newtab talos tests)? I also ran some regression range talos runs of https://github.com/facebook/react/compare/v16.8.6...v16.9.0 with 500+ commits, and seems to be between: ``` git lg 353e0ee47..fd601fb21 packages/react-dom/ * fce15f14d - don't fire missing act() warnings for react-art (#15975) (10 months ago) <Sunil Pai> * e1c5e8720 - warn if passive effects get queued outside of an act() call. (#15763) (10 months ago) <Sunil Pai> * 6568a7993 - [Scheduler] requestPaint (#15960) (10 months ago) <Andrew Clark> * dc298fdf9 - [Flare] Refinements to useEvent hook (#15955) (10 months ago) <Dominic Gannaway> * a5ed2f98f - [Flare] Guard against stateNode being null (#15952) (10 months ago) <Dominic Gannaway> * 34ce57ae7 - [Flare] Refine flow type annotations (#15950) (10 months ago) <Dominic Gannaway> * 4f92fbce5 - [Flare] Move createEvent back to React object (#15943) (10 months ago) <Dominic Gannaway> * 175111de7 - Lazily initialize dependencies object (#15944) (10 months ago) <Andrew Clark> * 720db4cbe - [Flare] Add useEvent hook implementation (#15927) (10 months ago) <Dominic Gannaway> * ff91bfa58 - [act] reset scope depth on synchronous errors (#15937) (10 months ago) <Sunil Pai> * 76864f7ff - Add SuspenseList Component (#15902) (10 months ago) <Sebastian Markbåge> * b62ae1642 - [Flare] Rename createEventComponent -> createEvent (#15929) (10 months ago) <Dominic Gannaway> * f4e1ac8ca - [Flare] Press events include defaultPrevented (#15916) (10 months ago) <Nicolas Gallagher> * 689beef6f - [Flare] Move unstable_createEventComponent to ReactDOM (#15890) (10 months ago) <Dominic Gannaway> ``` I'm also trying to see what was changed in 16.13 that might have fixed the regression…