Looks like my earlier bisecting was insufficient looking only at packages/react-dom changes. These should be the actual regression and improvement ranges as it goes by directly adjacent commits:
```js
improvement in 16.13.0:
7dc974542 [Flight] Chunks API (#17398)
"value": 72.49829930005188
9354dd275 Make HostComponent inexact (#17412)
"value": 72.74957626996914
4c270375e Favor fallthrough switch instead of case statements for work tags (#17648)
"value": 72.2495733775972
6fef7c47a Add a regression test for switching from Fragment to a component (#17647)
"value": 81.7496223556337
9fe103124 [react-interactions] Rename Flare APIs to deprecated and remove from RN (#17644)
"value": 80.24653838779838
regression in 16.9.0:
6ff4c9de1 [Flare] Press: fix stale deactivation region state (#15931)
"value": 77.74642849044015
7a4c3e3b7 Make global names more obscure (#15941)
"value": 78.0
270dc2e4d Add forwards and backwards options to SuspenseList (#15918)
"value": 77.0
5368f7316 [Flare] Fix keyboard keyup regression (#15938)
"value": 72.99324293474369
3d0af2aea Don't consider require-like calls to be likely HOCs (#15940)
"value": 73.48489779814429
```
So at least both the improvement commit https://github.com/facebook/react/commit/4c270375e and regressing commit https://github.com/facebook/react/commit/270dc2e4d are touching similar files `react-reconciler/src/ReactFiber*.js
Here's a script for future reference:
```py
for I in 7dc974542 6ff4c9de1
do for J in `seq 0 4`
do (
cd ~/Development/react/
git rh
git co $I~$J
git sh --oneline | head -1 >> ~/mozilla-central/tmp
yarn
yarn build react-dom/index --type=UMD_PROD
cp build/dist/react-dom.production.min.js ~/mozilla-central/browser/components/newtab/vendor/react-dom.js
)
./mach talos-test --activeTests about_newtab_with_snippets
grep value testing/mozharness/build/local.json | tail -1 >> tmp
done
echo >> tmp
done
```
Bug 1627569 Comment 6 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
Looks like my earlier bisecting was insufficient looking only at packages/react-dom changes. These should be the actual regression and improvement ranges as it goes by directly adjacent commits:
```js
improvement in 16.13.0:
7dc974542 [Flight] Chunks API (#17398)
"value": 72.49829930005188
9354dd275 Make HostComponent inexact (#17412)
"value": 72.74957626996914
4c270375e Favor fallthrough switch instead of case statements for work tags (#17648)
"value": 72.2495733775972
6fef7c47a Add a regression test for switching from Fragment to a component (#17647)
"value": 81.7496223556337
9fe103124 [react-interactions] Rename Flare APIs to deprecated and remove from RN (#17644)
"value": 80.24653838779838
regression in 16.9.0:
6ff4c9de1 [Flare] Press: fix stale deactivation region state (#15931)
"value": 77.74642849044015
7a4c3e3b7 Make global names more obscure (#15941)
"value": 78.0
270dc2e4d Add forwards and backwards options to SuspenseList (#15918)
"value": 77.0
5368f7316 [Flare] Fix keyboard keyup regression (#15938)
"value": 72.99324293474369
3d0af2aea Don't consider require-like calls to be likely HOCs (#15940)
"value": 73.48489779814429
```
So at least both the improvement commit https://github.com/facebook/react/commit/4c270375e and regressing commit https://github.com/facebook/react/commit/270dc2e4d are touching similar files `react-reconciler/src/ReactFiber*.js`
Here's a script for future reference:
```py
for I in 7dc974542 6ff4c9de1
do for J in `seq 0 4`
do (
cd ~/Development/react/
git rh
git co $I~$J
git sh --oneline | head -1 >> ~/mozilla-central/tmp
yarn
yarn build react-dom/index --type=UMD_PROD
cp build/dist/react-dom.production.min.js ~/mozilla-central/browser/components/newtab/vendor/react-dom.js
)
./mach talos-test --activeTests about_newtab_with_snippets
grep value testing/mozharness/build/local.json | tail -1 >> tmp
done
echo >> tmp
done
```
Looks like my earlier bisecting was insufficient looking only at `packages/react-dom` changes. These should be the actual regression and improvement ranges as it goes by directly adjacent commits:
```js
improvement in 16.13.0:
7dc974542 [Flight] Chunks API (#17398)
"value": 72.49829930005188
9354dd275 Make HostComponent inexact (#17412)
"value": 72.74957626996914
4c270375e Favor fallthrough switch instead of case statements for work tags (#17648)
"value": 72.2495733775972
6fef7c47a Add a regression test for switching from Fragment to a component (#17647)
"value": 81.7496223556337
9fe103124 [react-interactions] Rename Flare APIs to deprecated and remove from RN (#17644)
"value": 80.24653838779838
regression in 16.9.0:
6ff4c9de1 [Flare] Press: fix stale deactivation region state (#15931)
"value": 77.74642849044015
7a4c3e3b7 Make global names more obscure (#15941)
"value": 78.0
270dc2e4d Add forwards and backwards options to SuspenseList (#15918)
"value": 77.0
5368f7316 [Flare] Fix keyboard keyup regression (#15938)
"value": 72.99324293474369
3d0af2aea Don't consider require-like calls to be likely HOCs (#15940)
"value": 73.48489779814429
```
So at least both the improvement commit https://github.com/facebook/react/commit/4c270375e and regressing commit https://github.com/facebook/react/commit/270dc2e4d are touching similar files `packages/react-reconciler/src/ReactFiber*.js`
Here's a script for future reference:
```py
for I in 7dc974542 6ff4c9de1
do for J in `seq 0 4`
do (
cd ~/Development/react/
git rh
git co $I~$J
git sh --oneline | head -1 >> ~/mozilla-central/tmp
yarn
yarn build react-dom/index --type=UMD_PROD
cp build/dist/react-dom.production.min.js ~/mozilla-central/browser/components/newtab/vendor/react-dom.js
)
./mach talos-test --activeTests about_newtab_with_snippets
grep value testing/mozharness/build/local.json | tail -1 >> tmp
done
echo >> tmp
done
```