I think we should also add to this comment to make it clear that this is different than the partitioning we want in dFPI or other OA-based partioning: https://searchfox.org/mozilla-central/rev/d2cec90777d573585f8477d5170892e5dcdfb0ab/dom/base/nsGlobalWindowInner.cpp#4471-4474. Perhaps: > // For Partitioned Trackers, we expose a partitioned LocalStorage, which > // doesn't share data with other contexts, and it's just in memory. > // Partitioned localStorage is available only for trackers listed in the > // privacy.restrict3rdpartystorage.partitionedHosts pref. See > // nsContentUtils::IsURIInPrefList to know the syntax for the pref value. > // This is a temporary web-compatibility hack. This is unrelated to the > // partitioning provided by origin attributes (e.g., FPI, dFPI, or containers) Gary: I've assigned you to the bug since you already have a patch ready. Thanks for updating the test as well!
Bug 1630763 Comment 8 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
I think we should also add to this comment to make it clear that this is different than the partitioning we want in dFPI or other OA-based partioning: https://searchfox.org/mozilla-central/rev/d2cec90777d573585f8477d5170892e5dcdfb0ab/dom/base/nsGlobalWindowInner.cpp#4471-4474. Perhaps: > // For Partitioned Trackers, we expose a partitioned LocalStorage, which > // doesn't share data with other contexts, and it's just in memory. > // Partitioned localStorage is available only for trackers listed in the > // privacy.restrict3rdpartystorage.partitionedHosts pref. See > // nsContentUtils::IsURIInPrefList to know the syntax for the pref value. > // This is a temporary web-compatibility hack. This is unrelated to the > // partitioning provided by origin attributes (e.g., FPI, dFPI, or containers). Gary: I've assigned you to the bug since you already have a patch ready. Thanks for updating the test as well!
I think we should also add to this comment to make it clear that this is different than the partitioning we want in dFPI or other OA-based partioning: https://searchfox.org/mozilla-central/rev/d2cec90777d573585f8477d5170892e5dcdfb0ab/dom/base/nsGlobalWindowInner.cpp#4471-4474. Perhaps: > // For Partitioned Trackers, we expose a partitioned LocalStorage, which > // doesn't share data with other contexts, and it's just in memory. > // Partitioned localStorage is available only for trackers listed in the > // privacy.restrict3rdpartystorage.partitionedHosts pref. See > // nsContentUtils::IsURIInPrefList to know the syntax for the pref value. > // This is a temporary web-compatibility hack, and is unrelated to the > // partitioning provided by origin attributes (e.g., FPI, dFPI, or containers). Gary: I've assigned you to the bug since you already have a patch ready. Thanks for updating the test as well!