(In reply to Geoff Lankow (:darktrojan) from comment #10) > Does this mean the usage in CalICSCalendar.jsm is also wrong? A quick look > makes me think it is. Ah, good catch. I had looked at that but mistook `this` as a `CalICSCalendar` when it was merely an `httpHooks`. Fixed. > The jsdoc on prepHttpChannel could probably be > improved too (at least mentioning calICalendar would be good). I worked on it a bit. (I wish we documented our JSDoc conventions, particularly how to format long param descriptions that need to wrap. The JSDoc docs are no help on that. This was discussed some [here](https://bugzilla.mozilla.org/show_bug.cgi?id=1546606#c33) with no conclusion reached. In this case I wanted to avoid the narrow column of text on the right so I went with the style that does that.)
Bug 1630943 Comment 11 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
(In reply to Geoff Lankow (:darktrojan) from comment #10) > Does this mean the usage in CalICSCalendar.jsm is also wrong? A quick look > makes me think it is. Ah, good catch. I had looked at that but mistook `this` as a `CalICSCalendar` when it was merely an `httpHooks`. Fixed. > The jsdoc on prepHttpChannel could probably be > improved too (at least mentioning calICalendar would be good). I worked on it a bit. (I wish we documented our JSDoc conventions, particularly how to format long param descriptions that need to wrap. The JSDoc docs are no help on that. This was discussed some [here](https://bugzilla.mozilla.org/show_bug.cgi?id=1546606#c33) with no conclusion reached. In this case I wanted to avoid the narrow column of text on the right so I went with the style that does that.) Edit: I have not done a try run because we currently have an orange tree.
(In reply to Geoff Lankow (:darktrojan) from comment #10) > Does this mean the usage in CalICSCalendar.jsm is also wrong? A quick look > makes me think it is. Ah, good catch. I did look at that but mistook `this` as a `CalICSCalendar` when it was merely an `httpHooks`. Fixed. > The jsdoc on prepHttpChannel could probably be > improved too (at least mentioning calICalendar would be good). I worked on it a bit. (I wish we documented our JSDoc conventions, particularly how to format long param descriptions that need to wrap. The JSDoc docs are no help on that. This was discussed some [here](https://bugzilla.mozilla.org/show_bug.cgi?id=1546606#c33) with no conclusion reached. In this case I wanted to avoid the narrow column of text on the right so I went with the style that does that.) Edit: I have not done a try run because we currently have an orange tree.
(In reply to Geoff Lankow (:darktrojan) from comment #10) > Does this mean the usage in CalICSCalendar.jsm is also wrong? A quick look > makes me think it is. Ah, good catch. I did look at that but mistook `this` as a `CalICSCalendar` when it was merely an `httpHooks`. Fixed. > The jsdoc on prepHttpChannel could probably be > improved too (at least mentioning calICalendar would be good). I worked on it a bit. (I wish we documented our JSDoc conventions, particularly how to format long param descriptions that need to wrap. The JSDoc docs are no help on that. This was discussed some [here](https://bugzilla.mozilla.org/show_bug.cgi?id=1546606#c33) with no conclusion reached. In this case I wanted to avoid the narrow column of text on the right so I went with the style that does that.) Edit: try run: https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=434c7510fdb453cb2ec3cb48313e53c0e50279ca