Bug 1632957 Comment 0 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

The throttled animations/transitions might be not synced with those on the compositor, especially when we replace a running transform transition on the compositor. There are 2 possible issues ([per hiro mentioned in Riot](https://matrix.to/#/!UdwgDoPmQajdqBNuaA:mozilla.org/$7Dx-Rj9lhhyki1p-IVGa39qTk_9DnSctVRgir26PPTM?via=mozilla.org&via=matrix.org&via=igalia.com)):
1) we don't want to flush throttled animations in cases of mouse movement or some such, 2) we do want to flush throttled animations when the target animating element is dirty.

And for 1), there is an [issue](https://matrix.to/#/!UdwgDoPmQajdqBNuaA:mozilla.org/$xmgfH-MN28eVZmHu9Gxz5utC2yyxcJR2PWcRrskMC0M?via=mozilla.org&via=matrix.org&via=igalia.com) which causes some crashes when hiro hacked it.

So perhaps we should try 2) or any other way to avoid the mouse event from flushing the throttled animations?

We notice this issue when debugging Bug 1623425 after applying the patches of Bug 1626165.
The throttled animations/transitions might be not synced with those on the compositor, especially when we replace a running transform transition on the compositor. There are 2 possible issues per hiro mentioned in Riot:
1) we don't want to flush throttled animations in cases of mouse movement or some such, 2) we do want to flush throttled animations when the target animating element is dirty.

And for 1), there is an [issue](https://matrix.to/#/!UdwgDoPmQajdqBNuaA:mozilla.org/$xmgfH-MN28eVZmHu9Gxz5utC2yyxcJR2PWcRrskMC0M?via=mozilla.org&via=matrix.org&via=igalia.com) which causes some crashes when hiro hacked it.

So perhaps we should try 2) or any other way to avoid the mouse event from flushing the throttled animations?

We notice this issue when debugging Bug 1623425 after applying the patches of Bug 1626165.
The throttled animations/transitions might be not synced with those on the compositor, especially when we replace a running transform transition on the compositor. There are 2 possible issues per hiro mentioned in Riot:
1) we don't want to flush throttled animations in cases of mouse movement or some such, 2) we do want to flush throttled animations when the target animating element is dirty.

And for 1), there is an which causes some crashes when hiro hacked it:
> hiro: and for 1) I vaguely remember when I tried to remove the flush, there were crash bugs during stylo development that is that the dirty style bit for the element remains after traversal, and there was(is?) an assertion checking it after traversal. 
the assertion I mean, MOZ_RELEASE_ASSERT. it might be a relaxed one.  DIAGNOSTIC? I don't remember the exact name.

So perhaps we should try 2) or any other way to avoid the mouse event from flushing the throttled animations?

We notice this issue when debugging Bug 1623425 after applying the patches of Bug 1626165.
The throttled animations/transitions might be not synced with those on the compositor, especially when we replace a running transform transition on the compositor. There are 2 possible issues per hiro mentioned in Riot:
1) we don't want to flush throttled animations in cases of mouse movement or some such
2) we do want to flush throttled animations when the target animating element is dirty.

And for 1), there is an which causes some crashes when hiro hacked it:
> hiro: and for 1) I vaguely remember when I tried to remove the flush, there were crash bugs during stylo development that is that the dirty style bit for the element remains after traversal, and there was(is?) an assertion checking it after traversal. 
the assertion I mean, MOZ_RELEASE_ASSERT. it might be a relaxed one.  DIAGNOSTIC? I don't remember the exact name.

So perhaps we should try 2) or any other way to avoid the mouse event from flushing the throttled animations?

We notice this issue when debugging Bug 1623425 after applying the patches of Bug 1626165.

Back to Bug 1632957 Comment 0