Bug 1635488 Comment 6 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

# Pluses
* easy to implement, we already have MVP
* can check against race-conditions because of the sha
* PRs are easy to add if we need this - https://pygithub.readthedocs.io/en/latest/examples/PullRequest.html#create-a-new-pull-request
* tags are easy - https://pygithub.readthedocs.io/en/latest/github_objects/Tag.html?highlight=tag#github.Tag.Tag

# Minuses
* confusing non-granular write access for the Github token or Github user
* possible rate-limit future concern https://developer.github.com/v3/#rate-limiting
* side-effects of functions are not aparent at callsite
* possible deprecation of the Github APIs in the future versions
* only one file per changeset/commit via `update_file`
* harder to extend for future requests

Results: https://github.com/MihaiTabara/fenix/commit/2b79439542114e81145ee1de61126006631eca59#diff-5fb01c6f8b54d96c62af3415c51ffad3
# Pros
* easy to implement, we already have MVP
* can check against race-conditions because of the sha
* PRs are easy to add if we need this - https://pygithub.readthedocs.io/en/latest/examples/PullRequest.html#create-a-new-pull-request
* tags are easy - https://pygithub.readthedocs.io/en/latest/github_objects/Tag.html?highlight=tag#github.Tag.Tag

# Cons
* confusing non-granular write access for the Github token or Github user
* possible rate-limit future concern https://developer.github.com/v3/#rate-limiting
* side-effects of functions are not aparent at callsite
* possible deprecation of the Github APIs in the future versions
* only one file per changeset/commit via `update_file`
* harder to extend for future requests

Results: https://github.com/MihaiTabara/fenix/commit/2b79439542114e81145ee1de61126006631eca59#diff-5fb01c6f8b54d96c62af3415c51ffad3

Back to Bug 1635488 Comment 6