Bugzilla

I found the problem. Some of the tests in the extensions area and the highWater test in imap don't do imap SELECT first like happens when TB itself in running and sending URLs to imap protocol.  With my defective patch this caused some tests to fail that don't do a SELECT until much later. 

The fix in the attached diff now again does the mailbox discovery on the first URL if discovery is not in progress due to SELECT not occurring first. This allows the unit test to now pass.  It also still allows discovery to run in its own URL when SELECT occurs first and allows quicker access by TB to the messages. 

Here's the try build results for the discovery-fix-v2.diff:
https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=1488461e7eea52b51883ff63958f721a45102157

I need to do some more testing on this but could someone (Magnus and/or Ben) verify that the test results actually are passing (I was fooled before). I do see an error "bct3" but it appears that other try builds have the same error. I want to be sure the test results are OK before submitting another formal patch.

I found the problem. Some of the tests in the extensions area and the highWater test in imap don't do imap SELECT first like happens when TB itself is running and sending URLs to imap protocol.  With my defective patch this caused some tests to fail that don't do a SELECT until much later. 

The fix in the attached diff now again does the mailbox discovery on the first URL if discovery is not in progress due to SELECT not occurring first. This allows the unit test to now pass.  It also still allows discovery to run in its own URL when SELECT occurs first and allows quicker access by TB to the messages. 

Here's the try build results for the discovery-fix-v2.diff:
https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=1488461e7eea52b51883ff63958f721a45102157

I need to do some more testing on this but could someone (Magnus and/or Ben) verify that the test results actually are passing (I was fooled before). I do see an error "bct3" but it appears that other try builds have the same error. I want to be sure the test results are OK before submitting another formal patch.