Bug 1641121 Comment 3 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Original comment by
on 
Here's the current state of things for places that eventually call `toolbox.viewSourceInStyleEditorByURL` and `toolbox.viewSourceInDebugger` (without a guaranteed sourceID). 

* CSS error Console messages
  - No stylesheet actor IDs, opening files relies on URL.

* Network Event Console messages
  - No source actor ID known (and would need multiple to handle HTML w/ multiple scripts)
  - Possibly complicated by the fact that the trace may not be in same thread?
    - https://searchfox.org/mozilla-central/rev/027893497316897b8f292bde48dbb6da2391a331/devtools/server/actors/network-monitor/network-event.js#118-121

* JS error and log messages
  - Will not have an actor ID if the thread actor is not attached
  - Not entirely sure if every message is guaranteed to have a URL in a debuggee?

* EventTooltipHelper
  - Actor ID unavailable if the handler is not a debuggee or is not an "allowed source"

* Element inspector "jump to custom element"
  - No source actor IDs, opening files relies on URL.

* NetMonitor Request stacktraces
  - No source actor IDs, opening files relies on URL.

* Memory Pane Allocation Stacks
  - No source actor IDs, opening files relies on URL.

* Perf Recordings Stacks
  - No source actor IDs, opening files relies on URL.
Revision 1 by
on 
Here's the current state of things for places that eventually call `toolbox.viewSourceInStyleEditorByURL` and `toolbox.viewSourceInDebugger` (without a guaranteed sourceID). 

* CSS error Console messages
  - No stylesheet actor IDs, opening files relies on URL.

* Network Event Console messages
  - No source actor ID known (and would need multiple to handle HTML w/ multiple scripts)
  - Possibly complicated by the fact that the trace may not be in same thread?
    - https://searchfox.org/mozilla-central/rev/027893497316897b8f292bde48dbb6da2391a331/devtools/server/actors/network-monitor/network-event.js#118-121

* JS error and log messages
  - Will not have an actor ID if the thread actor is not attached
  - Not entirely sure if every message is guaranteed to have a URL in a debuggee?

* EventTooltipHelper
  - Actor ID unavailable if the handler is not a debuggee or is not an "allowed source"

* Element inspector "jump to custom element"
  - No source actor IDs, opening files relies on URL.

* NetMonitor Request stacktraces
  - No source actor IDs, opening files relies on URL.

* Memory Pane Allocation Stacks
  - No source actor IDs, opening files relies on URL.

* Perf Recordings Stacks
  - No source actor IDs, opening files relies on URL.

EDIT: Missed one:

* "Jump to Definition" in Reps for functions jumps to the function definition and provides no source actor ID

Back to Bug 1641121 Comment 3