It looks like we use https://www.npmjs.com/package/typescript-json-schema on https://github.com/mozilla/rapid-experiments-shared/ and keeping these the same seems like the way to go. I'm not sure if we should: 1. keep `JSONSchemaValidator.jsm` API-compatible and replace the internals w/ `typescript-json-schema` 2. add `typescript-json-schema` to m-c and automatically rewrite callers 3. add `typescript-json-schema` to m-c and let callers opt-in There aren't very many callers (looks like enterprise policy and urlbar components0 and I don't think there's anything especially great about the current API, so I am leaning towards #2 but might go with #3 if there are concerns.
Bug 1642737 Comment 1 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
It looks like we use https://www.npmjs.com/package/typescript-json-schema on https://github.com/mozilla/rapid-experiments-shared/ and keeping these the same seems like the way to go. I'm not sure if we should: 1. keep `JSONSchemaValidator.jsm` API-compatible and replace the internals w/ `typescript-json-schema` 2. add `typescript-json-schema` to m-c and automatically rewrite callers 3. add `typescript-json-schema` to m-c and let callers opt-in There aren't very many callers (looks like enterprise policy and urlbar components) and I don't think there's anything especially great about the current API, so I am leaning towards #2 but might go with #3 if there are concerns.
It looks like we use https://www.npmjs.com/package/@types/json-schema on https://github.com/mozilla/rapid-experiments-shared/ and keeping these the same seems like the way to go. I'm not sure if we should: 1. keep `JSONSchemaValidator.jsm` API-compatible and replace the internals w/ `json-schema` 2. add `json-schema` to m-c and automatically rewrite callers 3. add `json-schema` to m-c and let callers opt-in There aren't very many callers (looks like enterprise policy and urlbar components) and I don't think there's anything especially great about the current API, so I am leaning towards #2 but might go with #3 if there are concerns.
It looks like we use https://ajv.js.org/ on https://github.com/mozilla/rapid-experiments-shared/ and keeping these the same seems like the way to go. I'm not sure if we should: 1. keep `JSONSchemaValidator.jsm` API-compatible and replace the internals w/ `ajv` 2. add `ajv` to m-c and automatically rewrite callers 3. add `ajv` to m-c and let callers opt-in There aren't very many callers (looks like enterprise policy and urlbar components) and I don't think there's anything especially great about the current API, so I am leaning towards #2 but might go with #3 if there are concerns.