Good question. On x86/x64 (the only arches we use BCJ on), the only [opcodes used](https://git.tukaani.org/?p=xz.git;a=blob;f=src/liblzma/simple/x86.c;h=5d1509bb227807497ce34afe797bd5bb8faae9b5;hb=cd69a5a6c16c289f6f8e2823b03c72289472270f#l50) are 0xE8 (CALL short) and 0xE9 (JMP short), and as omni.ja is mostly ASCII text < 0x80 this shouldn't come up too often. For 77.0: file | BCJ | no BCJ | decrease --- | --- | --- | --- omni.ja | 4,816,116 | 4,803,712 | 12,404 browser/omni.ja | 11,836,084 | 11,837,088 | -1,004 It's weird that the size goes up slightly with browser/omni.ja, at that level it's likely just noise. I didn't want to include something like this in the patch because it's a little more complicated to check for these files, and adding a "non-exe" list would be a pain to maintain for little benefit.
Bug 1643211 Comment 3 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
Good question. On x86/x64 (the only arches we use BCJ on), the only [opcodes used](https://git.tukaani.org/?p=xz.git;a=blob;f=src/liblzma/simple/x86.c;h=5d1509bb227807497ce34afe797bd5bb8faae9b5;hb=cd69a5a6c16c289f6f8e2823b03c72289472270f#l50) are 0xE8 (CALL near) and 0xE9 (JMP near), and as omni.ja is mostly ASCII text < 0x80 this shouldn't come up too often. For 77.0: file | BCJ | no BCJ | decrease --- | --- | --- | --- omni.ja | 4,816,116 | 4,803,712 | 12,404 browser/omni.ja | 11,836,084 | 11,837,088 | -1,004 It's weird that the size goes up slightly with browser/omni.ja, at that level it's likely just noise. I didn't want to include something like this in the patch because it's a little more complicated to check for these files, and adding a "non-exe" list would be a pain to maintain for little benefit.