Bug 1645528 Comment 20 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

(In reply to Matt Woodrow (:mattwoodrow) from comment #19)
> I'm definitely concerned that moving the vsync notifications to run via the parent-process main thread will be a regression for Windows. It feels like we have quite different requirements per-platform, and trying to have a single solution might not be the best answer.

Fully agree on this, I definitely don't want to regress things here.

> I really like the idea of having the vsync thread run in the compositor process, and having notifications run across PCompositorBridge, when on Mac/Windows.
> 
> Could you make PVsync have two manager declarations, PBrowser and PBackground?
> 
> I think we could run PVsync over PBrowser when running Wayland, but keep the current setup as-is for other platforms (and then tackle moving it to PCompositorBridge as a separate project, I don't want to block you on that).

Sounds good to me - Markus, would that be fine for you?
(In reply to Matt Woodrow (:mattwoodrow) from comment #19)
> I'm definitely concerned that moving the vsync notifications to run via the parent-process main thread will be a regression for Windows. It feels like we have quite different requirements per-platform, and trying to have a single solution might not be the best answer.

Fully agree on this, I definitely don't want to regress things here.

> I really like the idea of having the vsync thread run in the compositor process, and having notifications run across PCompositorBridge, when on Mac/Windows.
> 
> Could you make PVsync have two manager declarations, PBrowser and PBackground?
> 
> I think we could run PVsync over PBrowser when running Wayland, but keep the current setup as-is for other platforms (and then tackle moving it to PCompositorBridge as a separate project, I don't want to block you on that).

Sounds good to me (if that's possible) - Markus, would that be fine for you?

Back to Bug 1645528 Comment 20