Bug 1645914 Comment 6 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Is this just supposed to disable the UI or the functionality as a whole? I noticed that the Enigmail-based OpenPGP implementation clashes with the pEp add-on left, right and centre. I had to nuke this so far ... and counting:

EnigmailVerify.registerContentTypeHandler - Causes bug 1646404
Enigmail.msg.sendMessageListener
Enigmail.msg.messengerStartup
Enigmail.hdrView.hdrViewLoad
Enigmail.hdrView.onShowAttachmentContextMenu

Basically all the stuff currently depending on MOZ_OPENPGP:
https://searchfox.org/comm-central/search?q=MOZ_OPENPGP&path=.js&case=false&regexp=false
Is this just supposed to disable the UI or the functionality as a whole? I noticed that the Enigmail-based OpenPGP implementation clashes with the pEp add-on left, right and centre. I had to nuke this so far ... and counting:

EnigmailVerify.registerContentTypeHandler - Causes bug 1646404
Enigmail.msg.sendMessageListener
Enigmail.msg.messengerStartup
Enigmail.hdrView.hdrViewLoad
Enigmail.hdrView.onShowAttachmentContextMenu

Basically all the stuff currently depending on MOZ_OPENPGP:
https://searchfox.org/comm-central/search?q=MOZ_OPENPGP&path=.js&case=false&regexp=false

EDIT: Oh, I see here https://hg.mozilla.org/comm-central/rev/3298f786eff2#l3.12 that the some of the stuff I mentioned above is taken care of, but not all, for example onShowAttachmentContextMenu here:
https://searchfox.org/comm-central/rev/9498b3d1accf12df749f19b88fb1d0a1fcad8d4d/mail/base/content/msgHdrView.js#2313
Is this just supposed to disable the UI or the functionality as a whole? I noticed that the Enigmail-based OpenPGP implementation clashes with the pEp add-on left, right and centre. I had to nuke this so far ... and counting:

EnigmailVerify.registerContentTypeHandler - Causes bug 1646404
Enigmail.msg.sendMessageListener
Enigmail.msg.messengerStartup
Enigmail.hdrView.hdrViewLoad
Enigmail.hdrView.onShowAttachmentContextMenu

Basically all the stuff currently depending on MOZ_OPENPGP:
https://searchfox.org/comm-central/search?q=MOZ_OPENPGP&path=.js&case=false&regexp=false

EDIT: Oh, I see here https://hg.mozilla.org/comm-central/rev/3298f786eff2#l3.12 that the some of the stuff I mentioned above is taken care of, but not all, for example onShowAttachmentContextMenu here:
https://searchfox.org/comm-central/rev/9498b3d1accf12df749f19b88fb1d0a1fcad8d4d/mail/base/content/msgHdrView.js#2313

EDIT 2: Maybe onShowAttachmentContextMenu is take care of by the changes in attachmentItemContext.inc.xhtml, and sendMessageListener() doesn't get added in composeStartup() if OpenPGG isn't fully initialised. That leaves some code which runs EnigmailVerify.registerContentTypeHandler. Let me try this in a Daily.
Is this just supposed to disable the UI or the functionality as a whole? I noticed that the Enigmail-based OpenPGP implementation clashes with the pEp add-on left, right and centre. I had to nuke this so far ... and counting:

EnigmailVerify.registerContentTypeHandler - Causes bug 1646404
Enigmail.msg.sendMessageListener
Enigmail.msg.messengerStartup
Enigmail.hdrView.hdrViewLoad
Enigmail.hdrView.onShowAttachmentContextMenu

Basically all the stuff currently depending on MOZ_OPENPGP:
https://searchfox.org/comm-central/search?q=MOZ_OPENPGP&path=.js&case=false&regexp=false

EDIT: Oh, I see here https://hg.mozilla.org/comm-central/rev/3298f786eff2#l3.12 that the some of the stuff I mentioned above is taken care of, but not all, for example onShowAttachmentContextMenu here:
https://searchfox.org/comm-central/rev/9498b3d1accf12df749f19b88fb1d0a1fcad8d4d/mail/base/content/msgHdrView.js#2313

EDIT 2: Maybe onShowAttachmentContextMenu is take care of by the changes in attachmentItemContext.inc.xhtml, and sendMessageListener() doesn't get added in composeStartup() if OpenPGP isn't fully initialised. That leaves some code which runs EnigmailVerify.registerContentTypeHandler. Let me try this in a Daily.

Back to Bug 1645914 Comment 6