Let's go with this now, maybe tweak some comments. > First, when recipients are moved from CC to BCC, that's clearly a change of recipients. Right. You need to read the context. A move is an add and a remove, so now we're not firing on the remove any more if it was part of a move. I tested it. > So here you're skipping `updateSendCommands(true);` which is inside `onRecipientsChanged(true);` Again, please read the context. Alex is calling onRecipientsChanged() up if an identity change in fact changed the recipients. The therefore remove the wholesale call which is correct. Anything else can go into a now bug, especially anything related to "content changed". Here we're just correcting bad firing of onRecipientsChanged().
Bug 1647050 Comment 69 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
Let's go with this now, maybe tweak some comments. > First, when recipients are moved from CC to BCC, that's clearly a change of recipients. Right. You need to read the context. A move is an add and a remove, so now we're not firing on the remove any more if it was part of a move. I tested it. > So here you're skipping `updateSendCommands(true);` which is inside `onRecipientsChanged(true);` Again, please read the context. Alex is calling onRecipientsChanged() further up if an identity change in fact changed the recipients. He therefore removed the wholesale call which is correct. Anything else can go into a now bug, especially anything related to "content changed". Here we're just correcting bad firing of onRecipientsChanged().