Bug 1650511 Comment 39 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

(In reply to Mark Hammond [:markh] [:mhammond] from comment #37)
> Thanks Mak. Is there any reason the deletion of a bookmark can't unconditionally call [cleanupPages](https://searchfox.org/mozilla-central/rev/aec3a901e6f6b3041b5ec457c9111a042cef1fb1/toolkit/components/places/History.sys.mjs#896)? I'm thinking of adding that to app-services but wondering if there's some reason that's dangerous?

Well, long term that's more or less the plan. I say more or less because I don't know if we're going to invoke cleanupPages, or rather a bookmark-related version of it. That's what I'd like Bug 1475582 to do.
The weekly cleanup was just intended as a short term workaround, not as a solution.
(In reply to Mark Hammond [:markh] [:mhammond] from comment #37)
> Thanks Mak. Is there any reason the deletion of a bookmark can't unconditionally call [cleanupPages](https://searchfox.org/mozilla-central/rev/aec3a901e6f6b3041b5ec457c9111a042cef1fb1/toolkit/components/places/History.sys.mjs#896)? I'm thinking of adding that to app-services but wondering if there's some reason that's dangerous?

Well, long term that's more or less the plan. I say more or less because I don't know if we're going to invoke cleanupPages, or rather a bookmark-related version of it. That's what I'd like Bug 1475582 to do, every code removing stuff should take care of its own orphans, rather than delegating.
The weekly cleanup was just intended as a short term workaround, not as a solution.

Back to Bug 1650511 Comment 39