Bug 1650852 Comment 6 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Original comment by
on 
(In reply to Ed Lee :Mardak from comment #3)
> The default sites set will have rich icons, but I suppose someone or an add-on could change the pref value to anything. Not sure if we need to support that initially although TippyTopService should handle converting a url to rich icon if we have it instead of having some custom logic.

Realizing  default.sites pref  is not available early enough and introduces  dependency on ActticityStream.jsm to intialize first for pref values to be available. Other option is to move DEFAULT_SITES by locale in its own module that's refrenced from ActivityStream and AboutWelcome, doing so still keeps dependency/wait  on browser.search.region set by Search Service to be available
Revision 1 by
on 
(In reply to Ed Lee :Mardak from comment #3)
> The default sites set will have rich icons, but I suppose someone or an add-on could change the pref value to anything. Not sure if we need to support that initially although TippyTopService should handle converting a url to rich icon if we have it instead of having some custom logic.

Realizing  default.sites pref  is not available early enough in firstrunand introduces  dependency on ActticityStream.jsm to intialize first for pref values to be available. Other option is to move DEFAULT_SITES by locale in its own module that's refrenced from ActivityStream and AboutWelcome, doing so still keeps dependency/wait  on browser.search.region set by Search Service to be available
Revision 2 by
on 
(In reply to Ed Lee :Mardak from comment #3)
> The default sites set will have rich icons, but I suppose someone or an add-on could change the pref value to anything. Not sure if we need to support that initially although TippyTopService should handle converting a url to rich icon if we have it instead of having some custom logic.

Realizing  default.sites pref  is not available early enough in first run and introduces  dependency on ActticityStream.jsm to intialize first for pref values to be available. Other option is to move DEFAULT_SITES by locale in its own module that's refrenced from ActivityStream and AboutWelcome, doing so still keeps dependency/wait  on browser.search.region set by Search Service to be available
Revision 3 by
on 
(In reply to Ed Lee :Mardak from comment #3)
> The default sites set will have rich icons, but I suppose someone or an add-on could change the pref value to anything. Not sure if we need to support that initially although TippyTopService should handle converting a url to rich icon if we have it instead of having some custom logic.

Realizing  default.sites pref  is not available early enough in first run and introduces  dependency on ActivityStream.jsm to intialize first for pref values to be available. Other option is to move DEFAULT_SITES by locale in its own module that's refrenced from ActivityStream and AboutWelcome, doing so still keeps dependency/wait  on browser.search.region set by Search Service to be available

Back to Bug 1650852 Comment 6