Bug 1651522 Comment 22 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

(In reply to Andrew Sutherland [:asuth] (he/him) from comment #21)
> In bug 1866627 reported against Firefox 122 there are reports of ServiceWorker processes being created/hanging around; is it possible that these changes might lead to a change in the behavior around calls to [nsIServiceWorkerInfo::attachDebugger](https://searchfox.org/mozilla-central/rev/9bc264fbc5d6e618d8f3b9677a8f5e8550b94dbc/dom/interfaces/base/nsIServiceWorkerManager.idl#41,80)?

Oh yes, that's a terrible mistake I did here.
These magic calls to `[attach,detach}Debugger` should only be called for Service Workers which actually relates to the currently debugged context.
At least when opening regular DevTools, debugging a Tab, only Service Workers related to that tab will be impacted.
But the issue would still remain for the Browser Toolbox, which is debugging all the service workers.
For that, we may have to further revisit this.
(In reply to Andrew Sutherland [:asuth] (he/him) from comment #21)
> In bug 1866627 reported against Firefox 122 there are reports of ServiceWorker processes being created/hanging around; is it possible that these changes might lead to a change in the behavior around calls to [nsIServiceWorkerInfo::attachDebugger](https://searchfox.org/mozilla-central/rev/9bc264fbc5d6e618d8f3b9677a8f5e8550b94dbc/dom/interfaces/base/nsIServiceWorkerManager.idl#41,80)?

Oh yes, that's a terrible mistake I did here.
These magic calls to `{attach,detach}Debugger` should only be called for Service Workers which actually relates to the currently debugged context.
At least when opening regular DevTools, debugging a Tab, only Service Workers related to that tab will be impacted.
But the issue would still remain for the Browser Toolbox, which is debugging all the service workers.
For that, we may have to further revisit this.

Back to Bug 1651522 Comment 22