We don't own the code. It is difficult getting changes upstreamed to Skia. And if it can't be upstreamed, I have to maintain patches indefinitely. I would suggest filing a bug upstream with them. In this case, I don't believe the change is justified given the constraints of the code. It just doesn't make sense to change something where the code clearly intends something, and the code is actually made more dangerous to satisfy a compiler warning. Sorry.
Bug 1653622 Comment 3 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
We don't own the code. It is difficult getting changes upstreamed to Skia. And if it can't be upstreamed, I have to maintain patches indefinitely. I would suggest filing a bug upstream with them. In this case, I don't believe the change is justified given the constraints of the code. It just doesn't make sense to change something where the code clearly intends that to be only modifying a subset of the destination buffer (not the whole thing). Sorry.