Bug 1653908 Comment 19 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

After more time poring over the code I tend to agree with Nathan's assessment in comment 18. The component manager should retain a strong reference of the service, so there should be no way for it to go out of scope, even w/o my patch. If we're failing before reaching that point though we have two problems:
* We're doing so silently, so it's going to be really hard where and why it's happening
* Even if we don't crash where we're crashing we would probably still fail to instance the service, which means we'd crash somewhere else anyway :-(
After more time poring over the code I tend to agree with Nathan's assessment in comment 18. The component manager should retain a strong reference of the service, so there should be no way for it to go out of scope, even w/o my patch. If we're failing before reaching that point though we have two problems:
* We're doing so silently, so it's going to be really hard finding where and why it's happening
* Even if we don't crash where we're crashing we would probably still fail to instance the service, which means we'd crash somewhere else anyway :-(

Back to Bug 1653908 Comment 19