Bug 1656329 Comment 4 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Original comment by
on 
Guessing from 

```
    #0 nsZipArchive::BuildSynthetics() src/modules/libjar/nsZipArchive.cpp:810:22 (libxul.so+0x1a4b70c)
    #1 nsZipArchive::FindInit(char const*, nsZipFind**) src/modules/libjar/nsZipArchive.cpp:562:17 (libxul.so+0x1a3a6c1)
    #2 nsHyphenationManager::LoadPatternListFromOmnijar(mozilla::Omnijar::Type) src/intl/hyphenation/glue/nsHyphenationManager.cpp:237:8 (libxul.so+0xc354de)
    #3 ...
```

and

```
    #0 nsZipArchive::GetItem(char const*) src/modules/libjar/nsZipArchive.cpp (libxul.so+0x1a39d09)
    #1 nsJAR::GetInputStreamWithSpec(nsTSubstring<char> const&, nsTSubstring<char> const&, nsIInputStream**) src/modules/libjar/nsJAR.cpp:269:18 (libxul.so+0x1a3a8bb)
    #2 
```

and code reading that we are accessing the same zip file, but on the main thread without going through `nsJar` (which seems to add a [protection for multithread usage](https://searchfox.org/mozilla-central/rev/07342ce09126c513540c1c343476e026cfa907bf/modules/libjar/nsJAR.h#81) that nsZipArchive on its own does not to have).
Revision 1 by
on 
Guessing from 

```
    #0 nsZipArchive::BuildSynthetics() src/modules/libjar/nsZipArchive.cpp:810:22 (libxul.so+0x1a4b70c)
    #1 nsZipArchive::FindInit(char const*, nsZipFind**) src/modules/libjar/nsZipArchive.cpp:562:17 (libxul.so+0x1a3a6c1)
    #2 nsHyphenationManager::LoadPatternListFromOmnijar(mozilla::Omnijar::Type) src/intl/hyphenation/glue/nsHyphenationManager.cpp:237:8 (libxul.so+0xc354de)
    #3 ...
```

and

```
    #0 nsZipArchive::GetItem(char const*) src/modules/libjar/nsZipArchive.cpp (libxul.so+0x1a39d09)
    #1 nsJAR::GetInputStreamWithSpec(nsTSubstring<char> const&, nsTSubstring<char> const&, nsIInputStream**) src/modules/libjar/nsJAR.cpp:269:18 (libxul.so+0x1a3a8bb)
    #2 
```

and code reading that we are accessing the same zip file, but on the main thread without going through `nsJar` (which seems to add a [protection for multithread usage](https://searchfox.org/mozilla-central/rev/07342ce09126c513540c1c343476e026cfa907bf/modules/libjar/nsJAR.h#81) that nsZipArchive on its own does not have).

Back to Bug 1656329 Comment 4