Bug 1657251 Comment 6 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Original comment by
on 
I'll take it. Our favicon code already knows about private tabs (to not save anything to disk), so I assume this should be easy to add.

(In reply to James Willcox (:snorp) (jwillcox@mozilla.com) (he/him) from comment #3)
> I think a-c just needs to pass FETCH_FLAGS_ANONYMOUS or FETCH_FLAGS_PRIVATE for favicon fetches.

(In reply to Daniel Veditz [:dveditz] from comment #2)
> Sending cookies with favicon isn't what we want, but by itself not so bad.

Just to clarify: Do we want ALL favicon fetches to use that flag? Or should we only use it for favicons of private tabs?
Revision 1 by
on 
I'll take it. Our favicon code already knows about private tabs (to not save anything to disk), so I assume this should be easy to add.


(In reply to James Willcox (:snorp) (jwillcox@mozilla.com) (he/him) from comment #3)
> I think a-c just needs to pass FETCH_FLAGS_ANONYMOUS or FETCH_FLAGS_PRIVATE for favicon fetches.

(In reply to Daniel Veditz [:dveditz] from comment #2)
> Sending cookies with favicon isn't what we want, but by itself not so bad.


Just to clarify: Do we want ALL favicon fetches to use that flag? Or should we only use it for favicons of private tabs?

Back to Bug 1657251 Comment 6