Bug 1659283 Comment 12 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

(In reply to Rob Wu [:robwu] from comment #10)
> When is `install.addon` null? (how did you test that?)
I tested that by placing a breakpoint in the Firefox JS Debugger, and checking if `install.addon` matched `this.addon`.
> Have you tried checking `.existingAddon`, to see if it has the expected value when `.addon` is null?
> 
Thanks for this - it does.
> The `install` object is an `AddinInstallWrapper`, instantiated here: https://searchfox.org/mozilla-central/rev/62c443a7c801ba9672de34c2867ec1665a4bbe67/toolkit/mozapps/extensions/internal/XPIInstall.jsm#1224-1262
> and the class itself is declared here: https://searchfox.org/mozilla-central/rev/62c443a7c801ba9672de34c2867ec1665a4bbe67/toolkit/mozapps/extensions/internal/XPIInstall.jsm#2622-2732
(In reply to Rob Wu [:robwu] from comment #10)
> When is `install.addon` null? (how did you test that?)

I tested that by placing a breakpoint in the Firefox JS Debugger, and checking if `install.addon` matched `this.addon`.

> Have you tried checking `.existingAddon`, to see if it has the expected value when `.addon` is null?
> 
Thanks for this - it does.
> The `install` object is an `AddinInstallWrapper`, instantiated here: https://searchfox.org/mozilla-central/rev/62c443a7c801ba9672de34c2867ec1665a4bbe67/toolkit/mozapps/extensions/internal/XPIInstall.jsm#1224-1262
> and the class itself is declared here: https://searchfox.org/mozilla-central/rev/62c443a7c801ba9672de34c2867ec1665a4bbe67/toolkit/mozapps/extensions/internal/XPIInstall.jsm#2622-2732
(In reply to Rob Wu [:robwu] from comment #10)
> When is `install.addon` null? (how did you test that?)

I tested that by placing a breakpoint in the Firefox JS Debugger, and checking if `install.addon` matched `this.addon`.

> Have you tried checking `.existingAddon`, to see if it has the expected value when `.addon` is null?
> 
Thanks for this - it does.

Back to Bug 1659283 Comment 12