I'm playing with the latest patch. In CI, we have a few options: 1. generate the changeset and possibly notify. A human will need to land the patch. 2. generate the changeset and submit it to Phabricator, flagging a review group for review. A human will need to review and Lando. 3. generate the changeset and push it to the strings repo without review. Do we want to rule any of the above out? (1) seems easiest to add to CI, but it can be prone to human error or bad actors. (2) seems preferable in terms of security and human verification, but still requires someone to do something. (3) is completely hands-off, but we lose the ability to catch issues before they land, and we have to open the repo up to automated writes without review.
Bug 1659691 Comment 8 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
I'm playing with the latest patch. In CI, we have a few options: 1. generate the changeset and possibly notify. A human will need to land the patch. 2. generate the changeset and submit it to Phabricator, flagging a review group for review. A human will need to review and Lando. 3. generate the changeset and push it to the strings repo without review. Do we want to rule any of the above out? (1) seems easiest to add to CI, but it can be prone to human error or bad actors. It could be an intermediate stopgap, however. (2) seems preferable in terms of security and human verification, but still requires someone to do something. (3) is completely hands-off, but we lose the ability to catch issues before they land, and we have to open the repo up to automated writes without review.