Ideally we would also rename all of the existing APIs (and all the variables that deal with their values, etc). I started looking into doing that, but that's a pretty large change; it should be non-functional, but there's a decent amount of room for human error since there's a lot of code that needs hand adjusting. (And I'm also not confident I understand or caught all of the frontend pieces.) So for now, I'm leaving the existing APIs in-place (with a XXXdholbert comments clarifying that they return sheet count, added in https://hg.mozilla.org/mozilla-central/rev/b13b671dfec9 ); and I'm going to call this new API "**raw**NumPages" (where "raw" = "unprocessed by page-ranges/pages-per-sheet). And we can distinguish variables/etc. using the same "raw" terminology for things that do really want this version.
Bug 1660502 Comment 1 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
Ideally we would also rename all of the existing APIs (and all the variables that deal with their values, etc) to use the term "sheets" instead of "pages". I started looking into doing that, but that's a pretty large change; it should be non-functional, but there's a decent amount of room for human error since there's a lot of code that needs hand adjusting. (And I'm also not confident I understand or caught all of the frontend pieces.) So for now, I'm leaving the existing APIs in-place (with a XXXdholbert comments clarifying that they return sheet count, added in https://hg.mozilla.org/mozilla-central/rev/b13b671dfec9 ); and I'm going to call this new API "**raw**NumPages" (where "raw" = "unprocessed by page-ranges/pages-per-sheet). And we can distinguish variables/etc. using the same "raw" terminology for things that do really want this version.
Ideally we would also rename all of the existing APIs (and all the variables that deal with their values, etc) to use the term "sheets" instead of "pages". I started looking into doing that, but that's a pretty large change; it should be non-functional, but there's a decent amount of room for human error since there's a lot of code that needs hand adjusting. (And I'm also not confident I understand or caught all of the frontend pieces.) So for now, I'm leaving the existing APIs in-place (with a XXXdholbert comments clarifying that they return sheet count, added in https://hg.mozilla.org/mozilla-central/rev/b13b671dfec9 ); and I'm going to call this new API "**raw**NumPages" (where "raw" = "unprocessed by page-ranges/pages-per-sheet"). And we can distinguish variables/etc. using the same "raw" terminology for things that do really want this version.