Bug 1665160 Comment 0 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Original comment by
on 
The changes to nsDOMNavigationTiming.cpp from bug 1657188 are triggering local build bustage for me:
```
In file included from Unified_cpp_dom_base8.cpp:38:
C:/Users/Ryan/repos/mozilla/dom/base/nsDocumentEncoder.cpp(1739,48): error: expected unqualified-id
      nsGkAtoms::s, nsGkAtoms::big, nsGkAtoms::small, nsGkAtoms::strike,
                                               ^
C:\Program Files (x86)\Windows Kits\10\include\10.0.19041.0\shared/rpcndr.h(190,15): note: expanded from macro 'small'
#define small char
              ^
```

Talking to Barret about it on Slack, this is probably due to the newly-added includes bringing in windows.h somewhere it didn't used to be. While this is currently only affecting my local build, this can presumably strike in CI at some point in the future if/when the unified file boundaries change from where they currently are.
Revision 1 by
on 
The changes to nsDOMNavigationTiming.cpp from bug 1657188 are triggering local build bustage for me:
https://hg.mozilla.org/integration/autoland/diff/dc8d6a216ffa28165acaf67ddc2e88974d95a8e9/dom/base/nsDOMNavigationTiming.cpp
```
In file included from Unified_cpp_dom_base8.cpp:38:
C:/Users/Ryan/repos/mozilla/dom/base/nsDocumentEncoder.cpp(1739,48): error: expected unqualified-id
      nsGkAtoms::s, nsGkAtoms::big, nsGkAtoms::small, nsGkAtoms::strike,
                                               ^
C:\Program Files (x86)\Windows Kits\10\include\10.0.19041.0\shared/rpcndr.h(190,15): note: expanded from macro 'small'
#define small char
              ^
```

Talking to Barret about it on Slack, this is probably due to the newly-added includes bringing in windows.h somewhere it didn't used to be. While this is currently only affecting my local build, this can presumably strike in CI at some point in the future if/when the unified file boundaries change from where they currently are.

Back to Bug 1665160 Comment 0