Bug 1665511 Comment 13 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

> Another thing I'd like to add is making it color customizable. Is this something we can do by adding a variable to the add on manifest?

I would use the themes API for that and add a new key to it, which can be used to style the space area like other parts of the UI, independent of a potential spaceActions API.

> > Is there a reason to not make it customizable like the others?
> 
> The short answer is " we have too many customizable toolbars and it's getting messy".
> Our customizable UI is completely different from the one used in Firefox, so we're supporting something completely foreign that it was intended to work with 1 main toolbar and nothing else. Adding another customizable toolbar is not optimal.
> 
> Also, toolbar customization is not keyboard accessible at all, so only "mouse-centric" users can benefit from that.
> Since the Spaces toolbar is gonna be the primary/default hub to open the main tabs, I want that to be fully accessible and customizable via keyboard.
> The customization of "Spaces" will be limited at first, with only the option to show/hide the toolbar, but later on I'd like to add menupopup options to change the order of buttons and hide unwanted buttons.
> 

Understood. In my head there is something wobbling that is something like the new Firefox customization page, which is customizing the entire pane/window and not an individual toolbar. That would solve so many issues. (including the message header toolbar bug which you picked up recently).  Just throwing that in here, since you seem to move towards a new/better kind of customization.
> Another thing I'd like to add is making it color customizable. Is this something we can do by adding a variable to the add on manifest?

I would use the themes API for that and add a new key to it, which can be used to style the space area like other parts of the UI, independent of a potential spaceActions API.

> > Is there a reason to not make it customizable like the others?
> 
> The short answer is " we have too many customizable toolbars and it's getting messy".
> Our customizable UI is completely different from the one used in Firefox, so we're supporting something completely foreign that it was intended to work with 1 main toolbar and nothing else. Adding another customizable toolbar is not optimal.
> 
> Also, toolbar customization is not keyboard accessible at all, so only "mouse-centric" users can benefit from that.
> Since the Spaces toolbar is gonna be the primary/default hub to open the main tabs, I want that to be fully accessible and customizable via keyboard.
> The customization of "Spaces" will be limited at first, with only the option to show/hide the toolbar, but later on I'd like to add menupopup options to change the order of buttons and hide unwanted buttons.
> 

Understood. In my head there is something wobbling that is like the new Firefox customization page, which is customizing the entire pane/window and not an individual toolbar. That would solve so many issues. (including the message header toolbar bug which you picked up recently).  Just throwing that in here, since you seem to move towards a new/better kind of customization.

Back to Bug 1665511 Comment 13