(In reply to Alessandro Castellani (:aleca) from comment #20) > So, what should we do with this patch? > > **Magnus' proposal:** Use `Alt+*` for the shortcuts to keep it consistent with the accesskeys. Alt+* = Access keys, which forces these "shortcuts" to be localized: - transition from gmail to TB made harder - they will end up different on every localization (imo, that's a disadvantage here) - which is a nightmare for support and documentation, and *not* helpful for enterprise deployment. - localization can break these keys easily (e.g. by not translating them, or overlooking duplicates) - choose between breaking main menu access keys/other access keys OR using unintuitive access keys here - furthermore, I would not introduce more important Alt+* access keys at this time as we might have to disbandon those if we switch to browser's Alt+Shift+* access keys. - less convenient on the keyboard > **Thomas' proposal:** Use `Ctrl+Shift+*` for the shortcuts to emulate the Gmail implementation. Ctrl+Shift+* = Shortcut keys. That will de facto (by Mozilla tradition) make these "shortcuts" internationally the same (typically not localized): - transition from gmail to TB made easy - easy for support and documentation, and helpful for enterprise deployment. - localization typically won't break these as they won't touch them - cannot break main menu access keys / other access keys or vice versa (as they are under developers' control) - reasonably intuitive internationally - does not affect localized access key design - relatively convenient to use because both modifiers are on the outer left edge on the keyboard, allowing a very controlled double-handed usage without twisting your hands or risk of errors.
Bug 1667692 Comment 22 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
(In reply to Alessandro Castellani (:aleca) from comment #20) > So, what should we do with this patch? > > **Magnus' proposal:** Use `Alt+*` for the shortcuts to keep it consistent with the accesskeys. Alt+* = Access keys, which forces these "shortcuts" to be localized: - they will end up different on every localization (imo, that's a disadvantage here) - which is a nightmare for support and documentation, and *not* helpful for enterprise deployment. - localization can break these keys easily (e.g. by not translating them, or overlooking duplicates) - choose between breaking main menu access keys/other access keys OR using unintuitive access keys here - furthermore, I would not introduce more important Alt+* access keys at this time as we might have to disbandon those if we switch to browser's Alt+Shift+* access keys. - less convenient on the keyboard - transition from gmail to TB made harder > **Thomas' proposal:** Use `Ctrl+Shift+*` for the shortcuts to emulate the Gmail implementation. Ctrl+Shift+* = Shortcut keys. That will de facto (by Mozilla tradition) make these "shortcuts" internationally the same (typically not localized): - easy for support and documentation, and helpful for enterprise deployment. - localization typically won't break these as they won't touch them - cannot break main menu access keys / other access keys or vice versa (as they are under developers' control) - reasonably intuitive internationally - does not affect localized access key design - relatively convenient to use because both modifiers are on the outer left edge on the keyboard, allowing a very controlled double-handed usage without twisting your hands or risk of errors. - transition from gmail to TB made easy