We should make sure that the onUpdated event for the "discarded" filter is correct. From what I understand in comment 15, listening for the discarded event will result in tab.discared == false during the TabBrowserInserted event. If that is indeed the case, we should instead listen for the "pending" attribute using "TabAttrModified". It seems we only have tests that watch for a tab being discarded, but not a test for when a tab is restored. I don't see any test that uses and tests the discarded filter. [1] https://searchfox.org/mozilla-central/rev/23c25cd32a1e87095301273937b4ee162f41e860/browser/components/extensions/test/browser/browser_ext_tabs_discard.js#55 [2] https://searchfox.org/mozilla-central/rev/23c25cd32a1e87095301273937b4ee162f41e860/browser/components/extensions/test/browser/browser_ext_tabs_discarded.js#79 [3] https://searchfox.org/mozilla-central/rev/23c25cd32a1e87095301273937b4ee162f41e860/browser/components/extensions/test/browser/browser_ext_tabs_onUpdated_filter.js#295
Bug 1669356 Comment 16 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
We should make sure that the onUpdated event for the "discarded" filter is correct. From what I understand in comment 15, listening for the discarded event will result in tab.discared == false during the TabBrowserInserted event. If that is indeed the case, we should instead listen for the "pending" attribute using "TabAttrModified". onUpdated with a discarded filter should fire when a tab is fully discarded or fully restored. It seems we only have tests that watch for a tab being discarded, but not a test for when a tab is restored. I don't see any test that uses and tests the discarded filter. [1] https://searchfox.org/mozilla-central/rev/23c25cd32a1e87095301273937b4ee162f41e860/browser/components/extensions/test/browser/browser_ext_tabs_discard.js#55 [2] https://searchfox.org/mozilla-central/rev/23c25cd32a1e87095301273937b4ee162f41e860/browser/components/extensions/test/browser/browser_ext_tabs_discarded.js#79 [3] https://searchfox.org/mozilla-central/rev/23c25cd32a1e87095301273937b4ee162f41e860/browser/components/extensions/test/browser/browser_ext_tabs_onUpdated_filter.js#295