I'm hoping to have the main patch up soon - I was hoping to post it today to land before the beta freeze tomorrow, but I'm not sure that'll happen. I've been needing to do a bit more digging than I was expecting, in order to get the orthogonal-page-vs-sheet-orientation stuff printing properly. There's a bit of complexity from the fact that this is creating a mode where the print settings say "portrait mode" and yet we really want to print landscape-oriented sheets of paper, which is necessary in order to e.g. have generated PDFs display the sheets on a virtual landscape-oriented piece of paper. I've got things working in print preview, and I had been naively imagining I could just adjust the sheet size in `PrintedSheetFrame::Reflow`, but in fact we need to do some special handling when generating the actual print target, and when responding to the various GetPageSize / GetOrientation APIs, since different callers may want different answers for the sheet vs. for the page. I'm still hoping this will end up relatively targeted & will be safe to land during the soft freeze and/or to uplift in early beta -- we'll see...
Bug 1669905 Comment 10 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
I'm hoping to have the main patch up soon - I was hoping to post it today to land before the beta freeze tomorrow, but I'm not sure that'll happen. I've been needing to do a bit more digging than I was expecting, in order to get the orthogonal-page-vs-sheet-orientation stuff printing properly. There's a bit of complexity from the fact that this is creating a mode where the print settings say "portrait mode" and yet we really want to print landscape-oriented sheets of paper, which is necessary in order to e.g. have generated PDFs display the sheets on a virtual landscape-oriented piece of paper. I've got things working in print preview, and I had been naively imagining I could just adjust the sheet size in `PrintedSheetFrame::Reflow`, but in fact we need to do some special handling when generating the actual print target, and when responding to the various GetPageSize / GetOrientation APIs, since different callers may want different answers depending on whether they're asking about the physical sheets vs. the layout on pages. I'm still hoping this will end up relatively targeted & will be safe to land during the soft freeze and/or to uplift in early beta -- we'll see...