Bug 1672384 Comment 13 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Oh ok!  So it will be like this:
`    if (primaryExtension == "pdf") {
      return (
        this.mLauncher.source === (this.mLauncher.source.schemeIs("blob") || 
        this.mLauncher.source.equalsExceptRef(browsingContext.currentWindowGlobal.documentURI)) ?
         &&
        !Services.prefs.getBoolPref("pdfjs.disabled", true) &&
        Services.prefs.getBoolPref(
          "browser.helperApps.showOpenOptionForPdfJS",
          false
        )
      );
    }`

As far as the testing goes, I'll confess, I have no experience with it, and I'm unsure quite where to start.  I notice that there's a couple of file paths defined at the beginning of the section `  for (let file of [
    "file_pdf_application_pdf.pdf",
    "file_pdf_binary_octet_stream.pdf",
  ]) `
Do I need to add anything there, or am I just going to add the the variables that follow?  Create something like:
`let differentPDF = await extraTab.anotherPDFPathHere`
Shot in the dark, i know, but I wanted to have something to offer.  Thank you for your guidance!
Oh ok!  So it will be like this:
```
    if (primaryExtension == "pdf") {
      return (
        this.mLauncher.source === (this.mLauncher.source.schemeIs("blob") || 
        this.mLauncher.source.equalsExceptRef(browsingContext.currentWindowGlobal.documentURI)) ?
         &&
        !Services.prefs.getBoolPref("pdfjs.disabled", true) &&
        Services.prefs.getBoolPref(
          "browser.helperApps.showOpenOptionForPdfJS",
          false
        )
      );
    }
```

As far as the testing goes, I'll confess, I have no experience with it, and I'm unsure quite where to start.  I notice that there's a couple of file paths defined at the beginning of the section `  for (let file of [
    "file_pdf_application_pdf.pdf",
    "file_pdf_binary_octet_stream.pdf",
  ]) `
Do I need to add anything there, or am I just going to add the the variables that follow?  Create something like:
`let differentPDF = await extraTab.anotherPDFPathHere`
Shot in the dark, i know, but I wanted to have something to offer.  Thank you for your guidance!

Back to Bug 1672384 Comment 13