Bug 1673196 Comment 4 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

### Beta/Release Uplift Approval Request
* **User impact if declined**: Password autocomplete doesn't show on fields using `aria-labelledby`
* **Is this code covered by automated tests?**: Yes
* **Has the fix been verified in Nightly?**: No
* **Needs manual test from QE?**: No
* **If yes, steps to reproduce**: 
* **List of other uplifts needed**: None
* **Risk to taking this patch**: Low
* **Why is the change risky/not risky? (and alternatives if risky)**: Straightforward change to use the appropriate root node but also added a truthiness check to handle when ID reference doesn't exist.
* **String changes made/needed**: None
### Beta/Release Uplift Approval Request
* **User impact if declined**: Password autocomplete doesn't show on fields using `aria-labelledby` with Shadow DOM. This affects popular apps like Home Assistant and other polymer apps.
* **Is this code covered by automated tests?**: Yes
* **Has the fix been verified in Nightly?**: No
* **Needs manual test from QE?**: No
* **If yes, steps to reproduce**: 
* **List of other uplifts needed**: None
* **Risk to taking this patch**: Low
* **Why is the change risky/not risky? (and alternatives if risky)**: Straightforward change to use the appropriate root node but also added a truthiness check to handle when ID reference doesn't exist.
* **String changes made/needed**: None

Back to Bug 1673196 Comment 4