Bug 1673229 Comment 3 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Original comment by
on 
Maybe here: https://searchfox.org/mozilla-central/rev/a147181ece866c1ecd176ac49f112785f960aac0/docshell/base/URIFixup.jsm#323-336

Since [COMMON_PROTOCOLS contains "ftp"](https://searchfox.org/mozilla-central/rev/a147181ece866c1ecd176ac49f112785f960aac0/docshell/base/URIFixup.jsm#79), Firefox will always consider it can handle ftp even if actually it cannot. 

We should remove "ftp" from COMMON_PROTOCOLS if network.ftp.enabled is false.
Revision 1 by
on 
Maybe here: https://searchfox.org/mozilla-central/rev/a147181ece866c1ecd176ac49f112785f960aac0/docshell/base/URIFixup.jsm#323-336

~~~Since COMMON_PROTOCOLS contains ftp,~~~ ~~~Firefox will always consider it can handle ftp even if actually it cannot.~~~

~~~We should remove "ftp" from COMMON_PROTOCOLS if network.ftp.enabled is false.~~~

EDIT: it did not work because `externalProtocolService.externalProtocolHandlerExists("ftp")` will return true.

Back to Bug 1673229 Comment 3