Bug 1673677 Comment 18 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Original comment by
on 
Probably we want to be handling this at the level of `nsTableWrapperFrame` (the outermost table box).

And it looks like that already has a `IsContainLayout()` fallback codepath that maybe would be appropriate to share here? (e.g. maybe we can just add `|| aWM.IsOrthogonalTo(GetWritingMode()))` to this condition):
https://searchfox.org/mozilla-central/rev/bce4b0be48762f15a1ad2ab52b6bdd42f5b0f0e1/layout/tables/nsTableWrapperFrame.cpp#29-35
```cpp
nscoord nsTableWrapperFrame::GetLogicalBaseline(
    WritingMode aWritingMode) const {
  if (StyleDisplay()->IsContainLayout()) {
    // We have no baseline. Fall back to the inherited impl which is
    // appropriate for this situation.
    return nsContainerFrame::GetLogicalBaseline(aWritingMode);
  }
```
Revision 1 by
on 
Probably we want to be handling this at the level of `nsTableWrapperFrame` (the outermost table box).

And it looks like that already has a `IsContainLayout()` fallback codepath that maybe would be appropriate to share here? (e.g. maybe we can just add `|| aWritingMode.IsOrthogonalTo(GetWritingMode()))` to this condition):
https://searchfox.org/mozilla-central/rev/bce4b0be48762f15a1ad2ab52b6bdd42f5b0f0e1/layout/tables/nsTableWrapperFrame.cpp#29-35
```cpp
nscoord nsTableWrapperFrame::GetLogicalBaseline(
    WritingMode aWritingMode) const {
  if (StyleDisplay()->IsContainLayout()) {
    // We have no baseline. Fall back to the inherited impl which is
    // appropriate for this situation.
    return nsContainerFrame::GetLogicalBaseline(aWritingMode);
  }
```
Revision 2 by
on 
Probably we want to be handling this at the level of `nsTableWrapperFrame` (the outermost table box).

And it looks like that already has a `IsContainLayout()` fallback codepath that maybe would be appropriate to share here? i.e. maybe we can just add `|| aWritingMode.IsOrthogonalTo(GetWritingMode()))` to this condition:
https://searchfox.org/mozilla-central/rev/bce4b0be48762f15a1ad2ab52b6bdd42f5b0f0e1/layout/tables/nsTableWrapperFrame.cpp#29-35
```cpp
nscoord nsTableWrapperFrame::GetLogicalBaseline(
    WritingMode aWritingMode) const {
  if (StyleDisplay()->IsContainLayout()) {
    // We have no baseline. Fall back to the inherited impl which is
    // appropriate for this situation.
    return nsContainerFrame::GetLogicalBaseline(aWritingMode);
  }
```

Back to Bug 1673677 Comment 18