Thanks for the detailed review. I updated all the notification variable to match what they actually area and what type of notification container they interact with. In this way, we won't have a bunch of random `gNotification` all around TB that we can't distinguish. I also found other small CSS problems, and some wrong parameters we were passing when appending the notification (eg. "null" as a string instead of null). If we decide to uplift this for 78, I prefer to create a patch variation with the shim variables, and keep trunk clean.
Bug 1673958 Comment 9 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
Thanks for the detailed review. I updated all the notification variable to match what they actually area and what type of notification container they interact with. In this way, we won't have a bunch of random `gNotification` all around TB that we can't distinguish. I also found other small CSS problems, and some wrong parameters we were passing when appending the notification (eg. "null" as a string instead of null). If we decide to uplift this for 78, I prefer to create a patch variation with the shim variables, and keep trunk clean. Try run to see how many things I broke: https://treeherder.mozilla.org/jobs?repo=try-comm-central&revision=e8e45dd12e999ba636459c8caa540a796dab0147