Bug 1675018 Comment 12 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

### Beta/Release Uplift Approval Request
* **User impact if declined**: Users are logged out of popular sites daily when using clear history on shutdown. We already have a hacky workaround that  prevents purging from running for these users, but that's also not great. This is a better solution (I hope).
* **Is this code covered by automated tests?**: Yes
* **Has the fix been verified in Nightly?**: No
* **Needs manual test from QE?**: Yes
* **If yes, steps to reproduce**: Note that this 
- Log into Google, Twitter and/or Facebook
- in about:preferences, enable "Clear History when Nightly closes" and in the "Settings.." sub-menu only enable **only** Browsing & Download History
- Restart your browser, which will clear your history
- Go to about:preferences and turn off "Clear History when Nightly closes" again (this is needed to work around our short-term fix for v83)
- In the browser toolbox, run
```
await Components.classes["@mozilla.org/purge-tracker-service;1"].getService(Components.interfaces.nsIPurgeTrackerService).purgeTrackingCookieJars()
```
- Visit Google, Twitter and/or Facebook again. The bug is that you're logged out now. You should have stayed logged in because you only wanted to clear history, not cookies.
* **List of other uplifts needed**: None
* **Risk to taking this patch**: Medium
* **Why is the change risky/not risky? (and alternatives if risky)**: This is a relatively complex patch that changes how we clear history, but it's well tested and we've waited with uplifting until the beginning of the beta cycle on purpose.
* **String changes made/needed**: None
### Beta/Release Uplift Approval Request
* **User impact if declined**: Users are logged out of popular sites daily when using clear history on shutdown. We already have a hacky workaround that  prevents purging from running for these users, but that's also not great. This is a better solution (I hope).
* **Is this code covered by automated tests?**: Yes
* **Has the fix been verified in Nightly?**: No
* **Needs manual test from QE?**: Yes
* **If yes, steps to reproduce**:
- Log into Google, Twitter and/or Facebook
- in about:preferences, enable "Clear History when Nightly closes" and in the "Settings.." sub-menu only enable **only** Browsing & Download History
- Restart your browser, which will clear your history
- Go to about:preferences and turn off "Clear History when Nightly closes" again (this is needed to work around our short-term fix for v83)
- In the browser toolbox, run
```
await Components.classes["@mozilla.org/purge-tracker-service;1"].getService(Components.interfaces.nsIPurgeTrackerService).purgeTrackingCookieJars()
```
- Visit Google, Twitter and/or Facebook again. The bug is that you're logged out now. You should have stayed logged in because you only wanted to clear history, not cookies.
* **List of other uplifts needed**: None
* **Risk to taking this patch**: Medium
* **Why is the change risky/not risky? (and alternatives if risky)**: This is a relatively complex patch that changes how we clear history, but it's well tested and we've waited with uplifting until the beginning of the beta cycle on purpose.
* **String changes made/needed**: None

Back to Bug 1675018 Comment 12