Bug 1675847 Comment 9 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Original comment by
on 
(In reply to Masayuki Nakano [:masayuki] (he/him)(JST, +0900) from comment #8)
> Although some header files include `mozilla/StaticPrefs_*.h`, but I don't like to include it from `EventNameList.h` for the build performance even if we could.

How many files need to include the StaticPref header if we did this? `dom/html` has `#define EVENT /* nothing */` so maybe only the 4 files in dom/base? https://searchfox.org/mozilla-central/search?q=%23define+EVENT%28&path=&case=true&regexp=false
Revision 1 by
on 
(In reply to Masayuki Nakano [:masayuki] (he/him)(JST, +0900) from comment #8)
> Although some header files include `mozilla/StaticPrefs_*.h`, but I don't like to include it from `EventNameList.h` for the build performance even if we could.

How many files need to include the StaticPref header if we did this? `dom/html` has `#define EVENT /* nothing */` so maybe only the 4 files in dom/base? https://searchfox.org/mozilla-central/search?q=%23define+EVENT%28&path=&case=true&regexp=false (Two of them are headers again, which can have more effect though)
Revision 2 by
on 
(In reply to Masayuki Nakano [:masayuki] (he/him)(JST, +0900) from comment #8)
> Although some header files include `mozilla/StaticPrefs_*.h`, but I don't like to include it from `EventNameList.h` for the build performance even if we could.

How many files need to include the StaticPref header if we did this? `dom/html` has `#define EVENT /* nothing */` so maybe only the 4 files in dom/base? https://searchfox.org/mozilla-central/search?q=%23define+EVENT%28&path=&case=true&regexp=false (Two of them are headers again, which can have more effect though. The other two already are using StaticPrefs_dom.)

Back to Bug 1675847 Comment 9