Review of attachment 9189894 [details] [diff] [review]: ----------------------------------------------------------------- Oop - I commented on the patch on bug 1622640 instead of here. Upshot: Looks good, although I think most of the error-code checking can be done with publicly-exposed NS_ERROR_ macros and mozilla::psm::ErrorIsOverridable().
Bug 1676141 Comment 7 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
Oop - I commented on the patch on bug 1622640 instead of here. Upshot: Looks good, although I think most of the error-code checking can be done with publicly-exposed NS_ERROR_ macros and [`mozilla::psm::ErrorIsOverridable()`](https://searchfox.org/mozilla-central/source/security/manager/ssl/NSSErrorsService.h#46).