There's a couple of approaches we can take for this: a) Go through all the tests expecting the old UI and introduce new tests that will handle the new one. b) Disable the new UI in Nightly and land it. Then we fix all the tests (in a separate bug). This separate bug will need to be fixed before deciding to flip the pref. c) Keep the new UI enabled by default in Nightly and set the "prompts.contentPromptSubDialog" pref to `false` in tests expecting the old UI. Ideally, we do option "a" here. But this suggests we will be adding more code to `TabDialogBox` to handle content prompt specific actions. Option "b" lets us get the work in Nightly right away and give us room to fix the tests.
Bug 1680637 Comment 11 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
There's a couple of approaches we can take for this: a) Go through all the tests expecting the old UI and introduce new tests that will handle the new one. b) Disable the new UI in Nightly and land it. Then we fix all the tests (in a separate bug). This separate bug will need to be fixed before deciding to flip the pref. c) Keep the new UI enabled by default in Nightly and set the "prompts.contentPromptSubDialog" pref to `false` in tests expecting the old UI. Ideally, we do option "a" here. But this suggests we will be adding more code to `TabDialogBox` to handle content prompt specific actions. Option "b" lets us get the work in Nightly right away and give us room to fix the tests. Option "c" also lets us get the work into Nightly, but this leaves us open to new bugs with the new UI as a result. Gijs and Jared, do you have any opinions on what we should here?
There's a couple of approaches we can take for this: a) Go through all the tests expecting the old UI and introduce new tests that will handle the new one. b) Disable the new UI in Nightly and land it. Then we fix all the tests (in a separate bug). This separate bug will need to be fixed before deciding to flip the pref. c) Keep the new UI enabled by default in Nightly and set the "prompts.contentPromptSubDialog" pref to `false` in tests expecting the old UI. Ideally, we do option "a" here. But this suggests we will be adding more code to `TabDialogBox` to handle content prompt specific actions. Option "b" lets us get the work in Nightly right away and give us room to fix the tests. Option "c" also lets us get the work into Nightly, but this leaves us open to new bugs (that are covered by the old UI) with the new UI as a result. Gijs and Jared, do you have any opinions on what we should here?