It probably does affect regular printing, but fortunately it's probably not a bug that users would be in a position to trigger (or notice, if they do trigger it). I think the issue here is that we're being overly respectful of the unwriteable margin values that we get back from the printer (and we're stomping on the values that the test is trying to manually use instead). Given that the unwriteable-margin values aren't user-exposed/editable [1], it shouldn't be possible (or at least easy) for a user to trigger this. [1] (I know these values are sort of exposed in about:config, but I seem to recall those are write-only? And if there are saved values in there that we're using, it's entirely likely they're junk and the printer-supplied values are better anyway.)
Bug 1680838 Comment 7 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
It probably does affect regular printing, but fortunately it's probably not a bug that users would be in a position to trigger (or notice, if they do trigger it). I think the issue here is that we're being overly respectful of the unwriteable margin values that we get back from the printer (and we're stomping on values in the nsIPrintSettings object that the test -- or more generally, the browser frontend code -- had manually provided & was trying to use instead). Given that the unwriteable-margin values aren't user-exposed/editable [1], it shouldn't be possible (or at least easy) for a user to trigger this. [1] (I know these values are sort of exposed in about:config, but I seem to recall those are write-only? And if there are saved values in there that we're using, it's entirely likely they're junk and the printer-supplied values are better anyway.)
It probably does affect regular printing, but fortunately it's probably not a bug that users would be in a position to trigger (or notice, if they do trigger it). I think the issue here is that we're being overly respectful of the unwriteable margin values that we get back from the printer (and we're stomping on values in the nsIPrintSettings object that the test -- or more generally, the browser frontend code -- had manually provided & was trying to use instead). Given that the unwriteable-margin values aren't user-exposed/editable [1], it shouldn't be possible (or at least easy) for a user to trigger this. [1] (I know these values are sort of exposed in about:config, but I seem to recall those are write-only? Or, if there are saved values in there that we're using, it's entirely likely they're junk and the printer-supplied values are better anyway.)