Bug 1680845 Comment 2 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Original comment by
on 
Ah, this bustage is triggered my patch:
gfx/thebes/gfxGdkNativeRenderer.cpp:8:
gfx/thebes/gfxPlatformGtk.h:12:
dist/include/mozilla/gfx/gfxVars.h:12:
ipc/ipdl/_ipdlheaders/mozilla/gfx/GraphicsMessages.h:25:
dist/include/mozilla/D3DMessageUtils.h:10:
dist/include/ipc/IPCMessageUtils.h:43:
dist/include/nsIWidget.h:27:
dist/include/mozilla/widget/IMEData.h:12:
dist/include/mozilla/WritingModes.h:12:
dist/include/mozilla/ComputedStyle.h:16:
dist/include/mozilla/ServoComputedData.h:12:
include/mozilla/ServoStyleConsts.h:751:3: error: expected identifier
```
I makes `widget/IMEData.h` include `mozilla/WritingModes.h` for making a class have `WritingMode` as a member. I'll add a hack into `IMEData.h`, but this becomes just a hidden bug of the include hell.
Revision 1 by
on 
Ah, this bustage is triggered my patch:
```
gfx/thebes/gfxGdkNativeRenderer.cpp:8:
gfx/thebes/gfxPlatformGtk.h:12:
dist/include/mozilla/gfx/gfxVars.h:12:
ipc/ipdl/_ipdlheaders/mozilla/gfx/GraphicsMessages.h:25:
dist/include/mozilla/D3DMessageUtils.h:10:
dist/include/ipc/IPCMessageUtils.h:43:
dist/include/nsIWidget.h:27:
dist/include/mozilla/widget/IMEData.h:12:
dist/include/mozilla/WritingModes.h:12:
dist/include/mozilla/ComputedStyle.h:16:
dist/include/mozilla/ServoComputedData.h:12:
include/mozilla/ServoStyleConsts.h:751:3: error: expected identifier
```
I makes `widget/IMEData.h` include `mozilla/WritingModes.h` for making a class have `WritingMode` as a member. I'll add a hack into `IMEData.h`, but this becomes just a hidden bug of the include hell.

Back to Bug 1680845 Comment 2